Skip to content

Commit a7c5734

Browse files
committed
ACP2E-1620: [QUANS] Scheduled import successfully runs despite errors in system.log file
- Fixed the CR comments.
1 parent 57850e4 commit a7c5734

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

app/code/Magento/ImportExport/Controller/Adminhtml/ImportResult.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ protected function addErrorMessages(
7979
$this->renderErrorMessages->renderMessages($errorAggregator)
8080
);
8181
} catch (\Exception $e) {
82-
foreach ($this->renderErrorMessages->getErrorMessages($errorAggregator) as $errorMessage) {
82+
foreach ($this->getErrorMessages($errorAggregator) as $errorMessage) {
8383
$resultBlock->addError($errorMessage);
8484
}
8585
}

app/code/Magento/ImportExport/Model/Import/RenderErrorMessages.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ public function renderMessages(
120120
* @param ProcessingErrorAggregatorInterface $errorAggregator
121121
* @return array
122122
*/
123-
public function getErrorMessages(ProcessingErrorAggregatorInterface $errorAggregator)
123+
public function getErrorMessages(ProcessingErrorAggregatorInterface $errorAggregator): array
124124
{
125125
$messages = [];
126126
$rowMessages = $errorAggregator->getRowsGroupedByErrorCode([], [AbstractEntity::ERROR_CODE_SYSTEM_EXCEPTION]);
@@ -136,7 +136,7 @@ public function getErrorMessages(ProcessingErrorAggregatorInterface $errorAggreg
136136
* @param ProcessingErrorAggregatorInterface $errorAggregator
137137
* @return ProcessingError[]
138138
*/
139-
public function getSystemExceptions(ProcessingErrorAggregatorInterface $errorAggregator)
139+
public function getSystemExceptions(ProcessingErrorAggregatorInterface $errorAggregator): array
140140
{
141141
return $errorAggregator->getErrorsByCode([AbstractEntity::ERROR_CODE_SYSTEM_EXCEPTION]);
142142
}
@@ -147,7 +147,7 @@ public function getSystemExceptions(ProcessingErrorAggregatorInterface $errorAgg
147147
* @param ProcessingErrorAggregatorInterface $errorAggregator
148148
* @return string
149149
*/
150-
public function createErrorReport(ProcessingErrorAggregatorInterface $errorAggregator)
150+
public function createErrorReport(ProcessingErrorAggregatorInterface $errorAggregator): string
151151
{
152152
$this->historyModel->loadLastInsertItem();
153153
$sourceFile = $this->reportHelper->getReportAbsolutePath($this->historyModel->getImportedFile());
@@ -166,7 +166,7 @@ public function createErrorReport(ProcessingErrorAggregatorInterface $errorAggre
166166
* @param string $fileName
167167
* @return string
168168
*/
169-
public function createDownloadUrlImportHistoryFile($fileName)
169+
public function createDownloadUrlImportHistoryFile($fileName): string
170170
{
171171
return $this->backendUrl->getUrl(self::IMPORT_HISTORY_FILE_DOWNLOAD_ROUTE, ['filename' => $fileName]);
172172
}

0 commit comments

Comments
 (0)