MC-19247: Broken translations with advanced bundling

- Add fake dictionary for js unit tests;

Author: adifucan

app/code/Magento/Translation/view/base/templates/dictionary.phtml

@@ -8,7 +8,7 @@
 $viewModel = $block->getData('dictionary_view_model');
 ?>
 <script>
-    define('text!dictionary', function () {
-        return "[]";
+    define('dictionary', function () {
+        return <?= /* @noEscape */ $viewModel->getTranslationDictionary() ?>;
     });
 </script>

dev/tests/js/jasmine/require.conf.js

@@ -19,6 +19,11 @@ require.config({
         'tests': '../../../../../../dev/tests/js/jasmine',
         'squire': '../../../../../../node_modules/squirejs/src/Squire'
     },
+    map: {
+        '*': {
+            dictionary: '../../../../../../dev/tests/js/jasmine/tests/lib/mage/fake-dictionary'
+        }
+    },
     shim: {
         squire: {
             exports: 'squire'

dev/tests/js/jasmine/tests/lib/mage/fake-dictionary.js

@@ -0,0 +1,8 @@
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+// Fake dictionary for js unit tests as real dictionary is defined is template and cannot be initialized by requirejs
+define([], function () {
+    return {};
+});

dev/tests/js/jasmine/tests/lib/mage/translate.test.js

@@ -14,6 +14,10 @@ define([
             $.mage.translate.add('Hello World!');
             expect('Hello World!').toEqual($.mage.translate.translate('Hello World!'));
         });
+        it('works with translation alias __', function () {
+            $.mage.translate.add('Hello World!');
+            expect('Hello World!').toEqual($.mage.__('Hello World!'));
+        });
         it('works with one array as parameter', function () {
             $.mage.translate.add(['Hello World!', 'Bonjour tout le monde!']);
             expect('Hello World!').toEqual($.mage.translate.translate('Hello World!'));
@@ -40,10 +44,6 @@ define([
             $.mage.translate.add('Hello World!', 'Bonjour tout le monde!');
             expect('Bonjour tout le monde!').toEqual($.mage.translate.translate('Hello World!'));
         });
-        it('works with translation alias __', function () {
-            $.mage.translate.add('Hello World!');
-            expect('Hello World!').toEqual($.mage.__('Hello World!'));
-        });
     });
 
 });

lib/web/mage/translate.js

@@ -6,7 +6,7 @@
 define([
     'jquery',
     'mage/mage',
-    'text!dictionary'
+    'dictionary'
 ], function ($, mage, dictionary) {
     'use strict';