Improved tests coverage

Author: rogyar

dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/SetShippingMethodsOnCartTest.php

@@ -55,6 +55,7 @@ protected function setUp()
      * Test for general routine of setting a shipping method on shopping cart
      *
      * @magentoApiDataFixture Magento/Checkout/_files/quote_with_address_saved.php
+     * @magentoApiDataFixture Magento/Checkout/_files/enable_all_shipping_methods.php
      */
     public function testSetShippingMethodOnCart()
     {
@@ -87,6 +88,7 @@ public function testSetShippingMethodOnCart()
 
     /**
      * @magentoApiDataFixture Magento/Checkout/_files/quote_with_address_saved.php
+     * @magentoApiDataFixture Magento/Checkout/_files/enable_all_shipping_methods.php
      */
     public function testSetFlatrateOnCart()
     {
@@ -100,19 +102,22 @@ public function testSetFlatrateOnCart()
 
     /**
      * @magentoApiDataFixture Magento/Checkout/_files/quote_with_address_saved.php
+     * @magentoApiDataFixture Magento/OfflineShipping/_files/tablerates_weight.php
+     * @magentoApiDataFixture Magento/Checkout/_files/enable_all_shipping_methods.php
      */
     public function testSetTableRatesOnCart()
     {
         $this->setShippingMethodAndCheckResponse(
             'tablerate',
             'bestway',
-            '15',
+            '10',
             'Best Way - Table Rate'
         );
     }
 
     /**
      * @magentoApiDataFixture Magento/Checkout/_files/quote_with_address_saved.php
+     * @magentoApiDataFixture Magento/Checkout/_files/enable_all_shipping_methods.php
      */
     public function testSetFreeShippingOnCart()
     {
@@ -126,6 +131,21 @@ public function testSetFreeShippingOnCart()
 
     /**
      * @magentoApiDataFixture Magento/Checkout/_files/quote_with_address_saved.php
+     * @magentoApiDataFixture Magento/Checkout/_files/enable_all_shipping_methods.php
+     */
+    public function testSetUpsOnCart()
+    {
+        $this->setShippingMethodAndCheckResponse(
+            'ups',
+            'GND',
+            '15.61',
+            'United Parcel Service - Ground'
+        );
+    }
+
+    /**
+     * @magentoApiDataFixture Magento/Checkout/_files/quote_with_address_saved.php
+     * @magentoApiDataFixture Magento/Checkout/_files/enable_all_shipping_methods.php
      */
     public function testSetShippingMethodWithWrongCartId()
     {
@@ -147,6 +167,7 @@ public function testSetShippingMethodWithWrongCartId()
 
     /**
      * @magentoApiDataFixture Magento/Checkout/_files/quote_with_address_saved.php
+     * @magentoApiDataFixture Magento/Checkout/_files/enable_all_shipping_methods.php
      */
     public function testSetNonExistingShippingMethod()
     {
@@ -174,6 +195,7 @@ public function testSetNonExistingShippingMethod()
 
     /**
      * @magentoApiDataFixture Magento/Checkout/_files/quote_with_address_saved.php
+     * @magentoApiDataFixture Magento/Checkout/_files/enable_all_shipping_methods.php
      */
     public function testSetShippingMethodWithNonExistingAddress()
     {
@@ -200,6 +222,7 @@ public function testSetShippingMethodWithNonExistingAddress()
 
     /**
      * @magentoApiDataFixture Magento/Checkout/_files/quote_with_address_saved.php
+     * @magentoApiDataFixture Magento/Checkout/_files/enable_all_shipping_methods.php
      */
     public function testSetShippingMethodByGuestToCustomerCart()
     {

dev/tests/integration/testsuite/Magento/Checkout/_files/enable_all_shipping_methods.php

@@ -0,0 +1,21 @@
+<?php
+
+use Magento\Framework\App\Config\Storage\Writer;
+use Magento\Framework\App\Config\Storage\WriterInterface;
+use Magento\TestFramework\Helper\Bootstrap;
+use Magento\Framework\App\Config\ScopeConfigInterface;
+
+$objectManager = Bootstrap::getObjectManager();
+/** @var Writer  $configWriter */
+$configWriter = $objectManager->create(WriterInterface::class);
+
+$configWriter->save('carriers/flatrate/active', 1);
+$configWriter->save('carriers/tablerate/active', 1);
+$configWriter->save('carriers/freeshipping/active', 1);
+$configWriter->save('carriers/ups/active', 1);
+$configWriter->save('carriers/usps/active', 1);
+$configWriter->save('carriers/fedex/active', 1);
+$configWriter->save('carriers/dhl/active', 1);
+
+$scopeConfig = $objectManager->get(ScopeConfigInterface::class);
+$scopeConfig->clean();

dev/tests/integration/testsuite/Magento/Checkout/_files/enable_all_shipping_methods_rollback.php

@@ -0,0 +1,17 @@
+<?php
+
+use Magento\Framework\App\Config\Storage\Writer;
+use Magento\Framework\App\Config\Storage\WriterInterface;
+use Magento\TestFramework\Helper\Bootstrap;
+
+$objectManager = Bootstrap::getObjectManager();
+/** @var Writer  $configWriter */
+$configWriter = $objectManager->create(WriterInterface::class);
+
+$configWriter->delete('carriers/flatrate/active');
+$configWriter->delete('carriers/tablerate/active');
+$configWriter->delete('carriers/freeshipping/active');
+$configWriter->delete('carriers/ups/active');
+$configWriter->delete('carriers/usps/active');
+$configWriter->delete('carriers/fedex/active');
+$configWriter->delete('carriers/dhl/active');

dev/tests/integration/testsuite/Magento/OfflineShipping/_files/tablerates_weight.php

@@ -0,0 +1,28 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+
+$objectManager = \Magento\TestFramework\Helper\Bootstrap::getObjectManager();
+$resource = $objectManager->get(\Magento\Framework\App\ResourceConnection::class);
+$connection = $resource->getConnection();
+$resourceModel = $objectManager->create(\Magento\OfflineShipping\Model\ResourceModel\Carrier\Tablerate::class);
+$entityTable = $resourceModel->getTable('shipping_tablerate');
+$data =
+    [
+        'website_id' => 1,
+        'dest_country_id' => 'US',
+        'dest_region_id' => 0,
+        'dest_zip' => '*',
+        'condition_name' => 'package_weight',
+        'condition_value' => 0,
+        'price' => 10,
+        'cost' => 0
+    ];
+$connection->query(
+    "INSERT INTO {$entityTable} (`website_id`,  `dest_country_id`, `dest_region_id`, `dest_zip`, `condition_name`,"
+    . "`condition_value`, `price`, `cost`) VALUES (:website_id,  :dest_country_id, :dest_region_id, :dest_zip,"
+    . " :condition_name, :condition_value, :price, :cost);",
+    $data
+);

dev/tests/integration/testsuite/Magento/OfflineShipping/_files/tablerates_weight_rollback.php

@@ -0,0 +1,7 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+
+require 'tablerates_rollback.php';