Merge pull request #27774 from lbajsarowicz/phpunit8/module-ImportExport

#27500 Prepare ImportExport module Tests for PHPUnit 8

Author: slavvka

app/code/Magento/ImportExport/Test/Unit/Block/Adminhtml/Export/FilterTest.php

@@ -3,112 +3,142 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
+
 namespace Magento\ImportExport\Test\Unit\Block\Adminhtml\Export;
 
+use Magento\Backend\Helper\Data;
+use Magento\Catalog\Model\Product\ReservedAttributeList;
+use Magento\Catalog\Model\ResourceModel\Product;
+use Magento\Eav\Api\Data\AttributeOptionInterfaceFactory;
+use Magento\Eav\Model\Config;
+use Magento\Eav\Model\Entity\Attribute;
+use Magento\Eav\Model\Entity\TypeFactory;
+use Magento\Eav\Model\ResourceModel\Helper;
+use Magento\Framework\Api\AttributeValueFactory;
+use Magento\Framework\Api\DataObjectHelper;
+use Magento\Framework\Api\ExtensionAttributesFactory;
+use Magento\Framework\Data\Collection\AbstractDb;
+use Magento\Framework\DataObject;
+use Magento\Framework\Escaper;
+use Magento\Framework\Filesystem;
+use Magento\Framework\Locale\Resolver;
+use Magento\Framework\Model\Context;
+use Magento\Framework\Reflection\DataObjectProcessor;
+use Magento\Framework\Registry;
+use Magento\Framework\Stdlib\DateTime\DateTimeFormatterInterface;
+use Magento\Framework\Stdlib\DateTime\Timezone;
 use Magento\Framework\TestFramework\Unit\Helper\ObjectManager as ObjectManagerHelper;
+use Magento\Framework\Validator\UniversalFactory;
+use Magento\Framework\View\Element\Html\Date;
+use Magento\Framework\View\Layout;
+use Magento\ImportExport\Block\Adminhtml\Export\Filter;
+use Magento\Store\Model\StoreManager;
+use PHPUnit\Framework\MockObject\MockObject;
+use PHPUnit\Framework\TestCase;
 
 /**
  * @SuppressWarnings(PHPMD)
  */
-class FilterTest extends \PHPUnit\Framework\TestCase
+class FilterTest extends TestCase
 {
     /**
-     * @var \Magento\Framework\Model\Context|\PHPUnit_Framework_MockObject_MockObject
+     * @var Context|MockObject
      */
     protected $modelContext;
 
     /**
-     * @var \Magento\Framework\Registry|\PHPUnit_Framework_MockObject_MockObject
+     * @var Registry|MockObject
      */
     protected $registry;
 
     /**
-     * @var \Magento\Framework\Api\ExtensionAttributesFactory|\PHPUnit_Framework_MockObject_MockObject
+     * @var ExtensionAttributesFactory|MockObject
      */
     protected $extensionFactory;
 
     /**
-     * @var \Magento\Framework\Api\AttributeValueFactory|\PHPUnit_Framework_MockObject_MockObject
+     * @var AttributeValueFactory|MockObject
      */
     protected $customAttributeFactory;
 
     /**
-     * @var \Magento\Eav\Model\Config|\PHPUnit_Framework_MockObject_MockObject
+     * @var Config|MockObject
      */
     protected $eavConfig;
 
     /**
-     * @var \Magento\Eav\Model\Entity\TypeFactory|\PHPUnit_Framework_MockObject_MockObject
+     * @var TypeFactory|MockObject
      */
     protected $eavTypeFactory;
 
     /**
-     * @var \Magento\Store\Model\StoreManager|\PHPUnit_Framework_MockObject_MockObject
+     * @var StoreManager|MockObject
      */
     protected $storeManager;
 
     /**
-     * @var \Magento\Eav\Model\ResourceModel\Helper|\PHPUnit_Framework_MockObject_MockObject
+     * @var Helper|MockObject
      */
     protected $resourceHelper;
 
     /**
-     * @var \Magento\Framework\Validator\UniversalFactory|\PHPUnit_Framework_MockObject_MockObject
+     * @var UniversalFactory|MockObject
      */
     protected $universalFactory;
 
     /**
-     * @var \Magento\Eav\Api\Data\AttributeOptionInterfaceFactory|\PHPUnit_Framework_MockObject_MockObject
+     * @var AttributeOptionInterfaceFactory|MockObject
      */
     protected $optionDataFactory;
 
     /**
-     * @var \Magento\Framework\Reflection\DataObjectProcessor|\PHPUnit_Framework_MockObject_MockObject
+     * @var DataObjectProcessor|MockObject
      */
     protected $dataObjectProcessor;
 
     /**
-     * @var \Magento\Framework\Api\DataObjectHelper|\PHPUnit_Framework_MockObject_MockObject
+     * @var DataObjectHelper|MockObject
      */
     protected $dataObjectHelper;
 
     /**
-     * @var \Magento\Framework\Stdlib\DateTime\Timezone|\PHPUnit_Framework_MockObject_MockObject
+     * @var Timezone|MockObject
      */
     protected $localeDate;
 
     /**
-     * @var \Magento\Catalog\Model\Product\ReservedAttributeList|\PHPUnit_Framework_MockObject_MockObject
+     * @var ReservedAttributeList|MockObject
      */
     protected $reservedAttributeList;
 
     /**
-     * @var \Magento\Framework\Locale\Resolver|\PHPUnit_Framework_MockObject_MockObject
+     * @var Resolver|MockObject
      */
     protected $localeResolver;
 
     /**
-     * @var \Magento\Catalog\Model\ResourceModel\Product|\PHPUnit_Framework_MockObject_MockObject
+     * @var Product|MockObject
      */
     protected $resource;
 
     /**
-     * @var \PHPUnit_Framework_MockObject_MockObject
+     * @var MockObject
      */
     protected $resourceCollection;
 
     /**
-     * @var \Magento\Backend\Block\Template\Context|\PHPUnit_Framework_MockObject_MockObject
+     * @var \Magento\Backend\Block\Template\Context|MockObject
      */
     protected $context;
 
     /**
-     * @var \Magento\Backend\Helper\Data|\PHPUnit_Framework_MockObject_MockObject
+     * @var Data|MockObject
      */
     protected $backendHelper;
 
     /**
-     * @var \Magento\ImportExport\Helper\Data|\PHPUnit_Framework_MockObject_MockObject
+     * @var \Magento\ImportExport\Helper\Data|MockObject
      */
     protected $importExportData;
 
@@ -118,36 +148,36 @@ class FilterTest extends \PHPUnit\Framework\TestCase
     protected $objectManagerHelper;
 
     /**
-     * @var \Magento\ImportExport\Block\Adminhtml\Export\Filter|\PHPUnit_Framework_MockObject_MockObject
+     * @var Filter|MockObject
      */
     protected $filter;
 
     /**
-     * @var \Magento\Framework\Stdlib\DateTime\DateTimeFormatterInterface|\PHPUnit_Framework_MockObject_MockObject
+     * @var DateTimeFormatterInterface|MockObject
      */
     private $dateTimeFormatter;
 
-    protected function setUp()
+    protected function setUp(): void
     {
-        $this->modelContext = $this->createMock(\Magento\Framework\Model\Context::class);
-        $this->registry = $this->createMock(\Magento\Framework\Registry::class);
-        $this->extensionFactory = $this->createMock(\Magento\Framework\Api\ExtensionAttributesFactory::class);
-        $this->customAttributeFactory = $this->createMock(\Magento\Framework\Api\AttributeValueFactory::class);
-        $this->eavConfig = $this->createMock(\Magento\Eav\Model\Config::class);
-        $this->eavTypeFactory = $this->createMock(\Magento\Eav\Model\Entity\TypeFactory::class);
-        $this->storeManager = $this->createMock(\Magento\Store\Model\StoreManager::class);
-        $this->resourceHelper = $this->createMock(\Magento\Eav\Model\ResourceModel\Helper::class);
-        $this->universalFactory = $this->createMock(\Magento\Framework\Validator\UniversalFactory::class);
-        $this->optionDataFactory = $this->createMock(\Magento\Eav\Api\Data\AttributeOptionInterfaceFactory::class);
-        $this->dataObjectProcessor = $this->createMock(\Magento\Framework\Reflection\DataObjectProcessor::class);
-        $this->dataObjectHelper = $this->createMock(\Magento\Framework\Api\DataObjectHelper::class);
-        $this->localeDate = $this->createMock(\Magento\Framework\Stdlib\DateTime\Timezone::class);
+        $this->modelContext = $this->createMock(Context::class);
+        $this->registry = $this->createMock(Registry::class);
+        $this->extensionFactory = $this->createMock(ExtensionAttributesFactory::class);
+        $this->customAttributeFactory = $this->createMock(AttributeValueFactory::class);
+        $this->eavConfig = $this->createMock(Config::class);
+        $this->eavTypeFactory = $this->createMock(TypeFactory::class);
+        $this->storeManager = $this->createMock(StoreManager::class);
+        $this->resourceHelper = $this->createMock(Helper::class);
+        $this->universalFactory = $this->createMock(UniversalFactory::class);
+        $this->optionDataFactory = $this->createMock(AttributeOptionInterfaceFactory::class);
+        $this->dataObjectProcessor = $this->createMock(DataObjectProcessor::class);
+        $this->dataObjectHelper = $this->createMock(DataObjectHelper::class);
+        $this->localeDate = $this->createMock(Timezone::class);
         $this->localeDate->expects($this->any())->method('getDateFormat')->will($this->returnValue('12-12-2012'));
-        $this->reservedAttributeList = $this->createMock(\Magento\Catalog\Model\Product\ReservedAttributeList::class);
-        $this->localeResolver = $this->createMock(\Magento\Framework\Locale\Resolver::class);
-        $this->resource = $this->createMock(\Magento\Catalog\Model\ResourceModel\Product::class);
+        $this->reservedAttributeList = $this->createMock(ReservedAttributeList::class);
+        $this->localeResolver = $this->createMock(Resolver::class);
+        $this->resource = $this->createMock(Product::class);
         $this->resourceCollection = $this->getMockForAbstractClass(
-            \Magento\Framework\Data\Collection\AbstractDb::class,
+            AbstractDb::class,
             [],
             '',
             false
@@ -156,33 +186,33 @@ protected function setUp()
             \Magento\Backend\Block\Template\Context::class,
             ['getFileSystem', 'getEscaper', 'getLocaleDate', 'getLayout']
         );
-        $filesystem = $this->createMock(\Magento\Framework\Filesystem::class);
+        $filesystem = $this->createMock(Filesystem::class);
         $this->context->expects($this->any())->method('getFileSystem')->will($this->returnValue($filesystem));
-        $escaper = $this->createPartialMock(\Magento\Framework\Escaper::class, ['escapeHtml']);
+        $escaper = $this->createPartialMock(Escaper::class, ['escapeHtml']);
         $escaper->expects($this->any())->method('escapeHtml')->will($this->returnValue(''));
         $this->context->expects($this->any())->method('getEscaper')->will($this->returnValue($escaper));
-        $timeZone = $this->createMock(\Magento\Framework\Stdlib\DateTime\Timezone::class);
+        $timeZone = $this->createMock(Timezone::class);
         $timeZone->expects($this->any())->method('getDateFormat')->will($this->returnValue('M/d/yy'));
         $this->context->expects($this->any())->method('getLocaleDate')->will($this->returnValue($timeZone));
         $dateBlock = $this->createPartialMock(
-            \Magento\Framework\View\Element\Html\Date::class,
+            Date::class,
             ['setValue', 'getHtml', 'setId', 'getId']
         );
         $dateBlock->expects($this->any())->method('setValue')->will($this->returnSelf());
         $dateBlock->expects($this->any())->method('getHtml')->will($this->returnValue(''));
         $dateBlock->expects($this->any())->method('setId')->will($this->returnSelf());
         $dateBlock->expects($this->any())->method('getId')->will($this->returnValue(1));
-        $layout = $this->createMock(\Magento\Framework\View\Layout::class);
+        $layout = $this->createMock(Layout::class);
         $layout->expects($this->any())->method('createBlock')->will($this->returnValue($dateBlock));
         $this->context->expects($this->any())->method('getLayout')->will($this->returnValue($layout));
-        $this->backendHelper = $this->createMock(\Magento\Backend\Helper\Data::class);
+        $this->backendHelper = $this->createMock(Data::class);
         $this->importExportData = $this->createMock(\Magento\ImportExport\Helper\Data::class);
         $this->dateTimeFormatter = $this->createMock(
-            \Magento\Framework\Stdlib\DateTime\DateTimeFormatterInterface::class
+            DateTimeFormatterInterface::class
         );
         $this->objectManagerHelper = new ObjectManagerHelper($this);
         $this->filter = $this->objectManagerHelper->getObject(
-            \Magento\ImportExport\Block\Adminhtml\Export\Filter::class,
+            Filter::class,
             [
                 'context' => $this->context,
                 'backendHelper' => $this->backendHelper,
@@ -202,7 +232,7 @@ protected function setUp()
     public function testDecorateFilter($attributeData, $backendType, $columnValue)
     {
         $value = '';
-        $attribute = new \Magento\Eav\Model\Entity\Attribute(
+        $attribute = new Attribute(
             $this->modelContext,
             $this->registry,
             $this->extensionFactory,
@@ -227,7 +257,7 @@ public function testDecorateFilter($attributeData, $backendType, $columnValue)
         $attribute->setOptions($attributeData['options']);
         $attribute->setFilterOptions($attributeData['filter_options']);
         $attribute->setBackendType($backendType);
-        $column = new \Magento\Framework\DataObject();
+        $column = new DataObject();
         $column->setData($columnValue, 'value');
         $isExport = true;
         $result = $this->filter->decorateFilter($value, $attribute, $column, $isExport);

app/code/Magento/ImportExport/Test/Unit/Block/Adminhtml/Grid/Column/Renderer/DownloadTest.php

@@ -3,14 +3,21 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
+
 namespace Magento\ImportExport\Test\Unit\Block\Adminhtml\Grid\Column\Renderer;
 
+use Magento\Backend\Block\Context;
+use Magento\Backend\Model\Url;
+use Magento\Framework\DataObject;
 use Magento\Framework\TestFramework\Unit\Helper\ObjectManager as ObjectManagerHelper;
+use Magento\ImportExport\Block\Adminhtml\Grid\Column\Renderer\Download;
+use PHPUnit\Framework\TestCase;
 
-class DownloadTest extends \PHPUnit\Framework\TestCase
+class DownloadTest extends TestCase
 {
     /**
-     * @var \Magento\Backend\Block\Context
+     * @var Context
      */
     protected $context;
 
@@ -20,24 +27,24 @@ class DownloadTest extends \PHPUnit\Framework\TestCase
     protected $objectManagerHelper;
 
     /**
-     * @var \Magento\ImportExport\Block\Adminhtml\Grid\Column\Renderer\Download
+     * @var Download
      */
     protected $download;
 
     /**
      * Set up
      */
-    protected function setUp()
+    protected function setUp(): void
     {
-        $urlModel = $this->createPartialMock(\Magento\Backend\Model\Url::class, ['getUrl']);
+        $urlModel = $this->createPartialMock(Url::class, ['getUrl']);
         $urlModel->expects($this->any())->method('getUrl')->willReturn('url');
-        $this->context = $this->createPartialMock(\Magento\Backend\Block\Context::class, ['getUrlBuilder']);
+        $this->context = $this->createPartialMock(Context::class, ['getUrlBuilder']);
         $this->context->expects($this->any())->method('getUrlBuilder')->willReturn($urlModel);
         $data = [];
 
         $this->objectManagerHelper = new ObjectManagerHelper($this);
         $this->download = $this->objectManagerHelper->getObject(
-            \Magento\ImportExport\Block\Adminhtml\Grid\Column\Renderer\Download::class,
+            Download::class,
             [
                 'context' => $this->context,
                 'data' => $data
@@ -51,7 +58,7 @@ protected function setUp()
     public function testGetValue()
     {
         $data = ['imported_file' => 'file.csv'];
-        $row = new \Magento\Framework\DataObject($data);
+        $row = new DataObject($data);
         $this->assertEquals('<p> file.csv</p><a href="url">Download</a>', $this->download->_getValue($row));
     }
 }