Skip to content

Commit ab39d6c

Browse files
committed
#16445 - getRegionHtmlSelect does not have configuration - added typehints for method arguments and return typehint
1 parent 49bc991 commit ab39d6c

File tree

1 file changed

+3
-2
lines changed
  • app/code/Magento/Directory/Block

1 file changed

+3
-2
lines changed

app/code/Magento/Directory/Block/Data.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
<?php
2+
declare(strict_types=1);
23
/**
34
* Copyright © Magento, Inc. All rights reserved.
45
* See COPYING.txt for license details.
@@ -176,7 +177,7 @@ public function getRegionCollection()
176177
* @deprecated
177178
* @see getRegionSelect() method for more configurations
178179
*/
179-
public function getRegionHtmlSelect()
180+
public function getRegionHtmlSelect(): string
180181
{
181182
return $this->getRegionSelect();
182183
}
@@ -190,7 +191,7 @@ public function getRegionHtmlSelect()
190191
* @param string $title
191192
* @return string
192193
*/
193-
public function getRegionSelect($value = null, $name = 'region', $id = 'state', $title = 'State/Province')
194+
public function getRegionSelect(string $value = null, string $name = 'region', string $id = 'state', string $title = 'State/Province'): string
194195
{
195196
\Magento\Framework\Profiler::start('TEST: ' . __METHOD__, ['group' => 'TEST', 'method' => __METHOD__]);
196197
if ($value === null) {

0 commit comments

Comments
 (0)