MAGETWO-69240: Unit Tests have different behavior between run for a bunch and a single test

igrybkov · igrybkov · commit ab85062a8c17 · 2017-05-18T13:26:45.000+03:00
- Mocked ObjectManager should return mocks
diff --git a/lib/internal/Magento/Framework/TestFramework/Unit/Listener/ReplaceObjectManager.php b/lib/internal/Magento/Framework/TestFramework/Unit/Listener/ReplaceObjectManager.php
@@ -32,6 +32,13 @@ public function startTest(\PHPUnit_Framework_Test $test)
         if ($test instanceof \PHPUnit_Framework_TestCase) {
             $objectManagerMock = $test->getMockBuilder(ObjectManagerInterface::class)
                 ->getMockForAbstractClass();
+            $createMockCallback = function ($type) use ($test) {
+                return $test->getMockBuilder($type)
+                    ->disableOriginalConstructor()
+                    ->getMockForAbstractClass();
+            };
+            $objectManagerMock->method('create')->willReturnCallback($createMockCallback);
+            $objectManagerMock->method('get')->willReturnCallback($createMockCallback);
             ObjectManager::setInstance($objectManagerMock);
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -32,6 +32,13 @@ public function startTest(\PHPUnit_Framework_Test $test)`
`32`	`32`	`if ($test instanceof \PHPUnit_Framework_TestCase) {`
`33`	`33`	`$objectManagerMock = $test->getMockBuilder(ObjectManagerInterface::class)`
`34`	`34`	`->getMockForAbstractClass();`
	`35`	`+ $createMockCallback = function ($type) use ($test) {`
	`36`	`+ return $test->getMockBuilder($type)`
	`37`	`+ ->disableOriginalConstructor()`
	`38`	`+ ->getMockForAbstractClass();`
	`39`	`+ };`
	`40`	`+ $objectManagerMock->method('create')->willReturnCallback($createMockCallback);`
	`41`	`+ $objectManagerMock->method('get')->willReturnCallback($createMockCallback);`
`35`	`42`	`ObjectManager::setInstance($objectManagerMock);`
`36`	`43`	`}`
`37`	`44`	`}`