Skip to content

Commit ac4879b

Browse files
AC-13182::[Upgrade Build] Manual Upgrade Build 2.4.7-p2 -> 2.4.8-beta1
1 parent df56e44 commit ac4879b

File tree

1 file changed

+2
-13
lines changed

1 file changed

+2
-13
lines changed

lib/internal/Magento/Framework/Mview/Config/Converter.php

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ protected function convertChild(\DOMNode $childNode, $data)
109109
}
110110
$name = $this->getAttributeValue($subscription, 'name');
111111
$column = $this->getAttributeValue($subscription, 'entity_column');
112-
$column = $this->checkColumnOrReturnPrimarykeyColumn($name, $column);
112+
$column = $this->checkifcolumnexist($name, $column);
113113
$subscriptionModel = $this->getAttributeValue($subscription, 'subscription_model');
114114

115115
if (!empty($subscriptionModel)
@@ -173,24 +173,13 @@ private function getAdditionalColumns(\DOMNode $subscription): array
173173
* @param string $columnName
174174
* @return string
175175
*/
176-
private function checkColumnOrReturnPrimarykeyColumn($tableName, $columnName)
176+
public function checkifcolumnexist($tableName, $columnName)
177177
{
178178
$connection = $this->resourceConnection->getConnection();
179179
$tableName = $this->resourceConnection->getTableName($tableName);
180180

181181
if (!$connection->isTableExists($tableName) || $connection->tableColumnExists($tableName, $columnName)) {
182182
return $columnName;
183183
}
184-
185-
$primarykeyColumn = null;
186-
$columns = $connection->describeTable($tableName);
187-
foreach ($columns as $column) {
188-
if (!empty($column['PRIMARY'])) {
189-
$primarykeyColumn = $column['COLUMN_NAME'];
190-
break;
191-
}
192-
}
193-
194-
return $primarykeyColumn;
195184
}
196185
}

0 commit comments

Comments
 (0)