Skip to content

Commit ae72fdd

Browse files
committed
Extract new feature to its own method
1 parent 4cca4c7 commit ae72fdd

File tree

1 file changed

+21
-10
lines changed

1 file changed

+21
-10
lines changed

app/code/Magento/Cron/Observer/ProcessCronQueueObserver.php

Lines changed: 21 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -365,16 +365,7 @@ protected function _runJob($scheduledTime, $currentTime, $jobConfig, $schedule,
365365
);
366366
}
367367

368-
if (!isset($this->originalProcessTitle)) {
369-
$this->originalProcessTitle = PHP_BINARY . ' ' . implode(' ', $this->environment->getServer('argv'));
370-
}
371-
372-
if (strpos($this->originalProcessTitle, " --group=$groupId ") !== false) {
373-
// Group is already shown, so no need to include here in duplicate
374-
cli_set_process_title($this->originalProcessTitle . " # job: $jobCode");
375-
} else {
376-
cli_set_process_title($this->originalProcessTitle . " # group: $groupId, job: $jobCode");
377-
}
368+
$this->setProcessTitle($jobCode, $groupId);
378369

379370
$schedule->setExecutedAt(date('Y-m-d H:i:s', $this->dateTime->gmtTimestamp()));
380371
$this->retrier->execute(
@@ -954,4 +945,24 @@ function () use ($scheduleResource, $where) {
954945
$scheduleResource->getConnection()
955946
);
956947
}
948+
949+
/**
950+
* Set the process title to include the job code and group
951+
*
952+
* @param string $jobCode
953+
* @param string $groupId
954+
*/
955+
private function setProcessTitle(string $jobCode, string $groupId): void
956+
{
957+
if (!isset($this->originalProcessTitle)) {
958+
$this->originalProcessTitle = PHP_BINARY . ' ' . implode(' ', $this->environment->getServer('argv'));
959+
}
960+
961+
if (strpos($this->originalProcessTitle, " --group=$groupId ") !== false) {
962+
// Group is already shown, so no need to include here in duplicate
963+
cli_set_process_title($this->originalProcessTitle . " # job: $jobCode");
964+
} else {
965+
cli_set_process_title($this->originalProcessTitle . " # group: $groupId, job: $jobCode");
966+
}
967+
}
957968
}

0 commit comments

Comments
 (0)