🔃 [Magento Community Engineering] Community Contributions - 2.3-develop

Accepted Community Pull Requests:
 - #23250: Fixed #23238 Apply button act like remove button while create new order from admin (by @gauravagarwal1001)
 - #23248: fix tooltip toggle selector typo (by @Karlasa)
 - #23244: Update CONTRIBUTING.md (by @diazwatson)
 - #23216: Fixed #23213 Static content deploy showing percentage symbol two times in progress bar (by @amitvishvakarma)
 - #22942: Fixed issue #18337 (by @geet07)


Fixed GitHub Issues:
 - #23238: Apply coupon button act like remove coupon while create new order from admin (reported by @renard123) has been fixed in #23250 by @gauravagarwal1001 in 2.3-develop branch
   Related commits:
     1. 6f5fc6e

 - #23213: Static content deploy showing percentage(%) two times in progress bar (reported by @amitvishvakarma) has been fixed in #23216 by @amitvishvakarma in 2.3-develop branch
   Related commits:
     1. 559555c

 - #18337: #search input is missing required attribute aria-expanded. (reported by @BezV8) has been fixed in #22942 by @geet07 in 2.3-develop branch
   Related commits:
     1. eeae4b2
     2. c3955b2
     3. bf4fbf0
     4. 81c722d

Author: magento-engcom-team

.github/CONTRIBUTING.md

@@ -11,7 +11,7 @@ The Magento 2 development team or community maintainers will review all issues a
 During the review we might require clarifications from the contributor.
 If there is no response from the contributor within two weeks, the pull request will be closed.
 
-For more detialed information on contribution please read our [beginners guide](https://github.com/magento/magento2/wiki/Getting-Started).
+For more detailed information on contribution please read our [beginners guide](https://github.com/magento/magento2/wiki/Getting-Started).
 
 ## Contribution requirements
 

app/code/Magento/Deploy/Console/ConsoleLogger.php

@@ -271,7 +271,7 @@ private function renderProgressBar(OutputInterface $output, array $process)
         return "{$title}{$titlePad}"
         . "{$count}{$countPad}"
         . "{$this->renderBar($output, $process)} "
-        . "{$percent}%{$percentPad}"
+        . "{$percent}{$percentPad}"
         . "{$process['elapsed']}   ";
     }
 

app/code/Magento/Sales/view/adminhtml/templates/order/create/coupons/form.phtml

@@ -10,8 +10,10 @@
 <div class="admin__field field-apply-coupon-code">
     <label class="admin__field-label"><span><?= $block->escapeHtml(__('Apply Coupon Code')) ?></span></label>
     <div class="admin__field-control">
+        <?php if (!$block->getCouponCode()) : ?>
         <input type="text" class="admin__control-text" id="coupons:code" value="" name="coupon_code" />
-        <?= $block->getButtonHtml(__('Apply'), 'order.applyCoupon($F(\'coupons:code\'))') ?>
+            <?= $block->getButtonHtml(__('Apply'), 'order.applyCoupon($F(\'coupons:code\'))') ?>
+        <?php endif; ?>
         <?php if ($block->getCouponCode()) : ?>
         <p class="added-coupon-code">
             <span><?= $block->escapeHtml($block->getCouponCode()) ?></span>

app/code/Magento/Search/view/frontend/templates/form.mini.phtml

@@ -35,7 +35,8 @@ $helper = $this->helper(\Magento\Search\Helper\Data::class);
                            role="combobox"
                            aria-haspopup="false"
                            aria-autocomplete="both"
-                           autocomplete="off"/>
+                           autocomplete="off"
+                           aria-expanded="false"/>
                     <div id="search_autocomplete" class="search-autocomplete"></div>
                     <?= $block->getChildHtml() ?>
                 </div>

app/code/Magento/Search/view/frontend/web/js/form-mini.js

@@ -71,7 +71,7 @@ define([
                     this.isExpandable = true;
                 }.bind(this),
                 exit: function () {
-                    this.isExpandable = false;
+                    this.isExpandable = true;
                 }.bind(this)
             });
 

app/design/frontend/Magento/blank/web/css/source/_tooltips.less

@@ -11,9 +11,9 @@
 
     .tooltip.wrapper {
         .lib-tooltip(
-        @_tooltip-position: bottom,
-        @_tooltip-selector-content: ~'.tooltip.content',
-        @_tooltip-selector-toggle: ~'tooltip.toggle'
+            @_tooltip-position: bottom,
+            @_tooltip-selector-content: ~'.tooltip.content',
+            @_tooltip-selector-toggle: ~'.tooltip.toggle'
         );
 
         .tooltip.content {