AC-1271: Add rate limiting for payment information endpoint and mutation

Author: arhiopterecs

app/code/Magento/GraphQl/Model/Backpressure/BackpressureContextFactory.php

@@ -10,12 +10,12 @@
 
 use Magento\Framework\App\Backpressure\ContextInterface;
 use Magento\Framework\App\Backpressure\IdentityProviderInterface;
+use Magento\Framework\App\ObjectManager;
 use Magento\Framework\App\RequestInterface;
 use Magento\Framework\GraphQl\Config\Element\Field;
-use Magento\Framework\HTTP\PhpEnvironment\RemoteAddress;
 
 /**
- * Creates context for fields.
+ * Creates context for fields
  */
 class BackpressureContextFactory
 {
@@ -50,7 +50,7 @@ public function __construct(
     }
 
     /**
-     * Creates context if possible.
+     * Creates context if possible
      *
      * @param Field $field
      * @return ContextInterface|null
@@ -62,12 +62,15 @@ public function create(Field $field): ?ContextInterface
             return null;
         }
 
-        return new GraphQlContext(
-            $this->request,
-            $this->identityProvider->fetchIdentity(),
-            $this->identityProvider->fetchIdentityType(),
-            $typeId,
-            $field->getResolver()
+        return ObjectManager::getInstance()->create(
+            GraphQlContext::class,
+            [
+                $this->request,
+                $this->identityProvider->fetchIdentity(),
+                $this->identityProvider->fetchIdentityType(),
+                $typeId,
+                $field->getResolver()
+            ]
         );
     }
 }

app/code/Magento/GraphQl/Model/Backpressure/BackpressureFieldValidator.php

@@ -15,7 +15,7 @@
 use Magento\Framework\GraphQl\Query\Resolver\Argument\ValidatorInterface;
 
 /**
- * Enforces backpressure for queries/mutations.
+ * Enforces backpressure for queries/mutations
  */
 class BackpressureFieldValidator implements ValidatorInterface
 {
@@ -47,14 +47,16 @@ public function __construct(
     public function validate(Field $field, $args): void
     {
         $context = $this->backpressureContextFactory->create($field);
-        if ($context) {
-            try {
-                $this->backpressureEnforcer->enforce($context);
-            } catch (BackpressureExceededException $exception) {
-                throw new GraphQlInputException(
-                    __('Something went wrong while processing the request. Try again later')
-                );
-            }
+        if (!$context) {
+            return;
+        }
+
+        try {
+            $this->backpressureEnforcer->enforce($context);
+        } catch (BackpressureExceededException $exception) {
+            throw new GraphQlInputException(
+                __('Something went wrong while processing the request. Try again later')
+            );
         }
     }
 }

app/code/Magento/GraphQl/Model/Backpressure/CompositeRequestTypeExtractor.php

@@ -11,7 +11,7 @@
 use Magento\Framework\GraphQl\Config\Element\Field;
 
 /**
- * Extracts using other extractors.
+ * Extracts using other extractors
  */
 class CompositeRequestTypeExtractor implements RequestTypeExtractorInterface
 {

app/code/Magento/GraphQl/Model/Backpressure/GraphQlContext.php

@@ -11,6 +11,9 @@
 use Magento\Framework\App\Backpressure\ContextInterface;
 use Magento\Framework\App\RequestInterface;
 
+/**
+ * GraphQl request context
+ */
 class GraphQlContext implements ContextInterface
 {
     /**
@@ -92,7 +95,7 @@ public function getTypeId(): string
     }
 
     /**
-     * Field's resolver class name.
+     * Field's resolver class name
      *
      * @return string
      */

app/code/Magento/GraphQl/Model/Backpressure/RequestTypeExtractorInterface.php

@@ -11,12 +11,12 @@
 use Magento\Framework\GraphQl\Config\Element\Field;
 
 /**
- * Extracts request type for fields.
+ * Extracts request type for fields
  */
 interface RequestTypeExtractorInterface
 {
     /**
-     * Extracts type ID if possible.
+     * Extracts type ID if possible
      *
      * @param Field $field
      * @return string|null

app/code/Magento/QuoteGraphQl/Model/BackpressureRequestTypeExtractor.php

@@ -15,7 +15,7 @@
 use ReflectionException;
 
 /**
- * Identifies which quote fields need backpressure management.
+ * Identifies which quote fields need backpressure management
  */
 class BackpressureRequestTypeExtractor implements RequestTypeExtractorInterface
 {
@@ -38,13 +38,10 @@ public function __construct(OrderLimitConfigManager $config)
     public function extract(Field $field): ?string
     {
         $fieldResolver = $this->resolver($field->getResolver());
-
         $placeOrderName = $this->resolver(PlaceOrder::class);
-
         $setPaymentAndPlaceOrder = $this->resolver(SetPaymentAndPlaceOrder::class);
 
-        if (($field->getResolver() === $setPaymentAndPlaceOrder ||
-                $placeOrderName  ===  $fieldResolver)
+        if (($field->getResolver() === $setPaymentAndPlaceOrder || $placeOrderName  ===  $fieldResolver)
             && $this->config->isEnforcementEnabled()
         ) {
             return OrderLimitConfigManager::REQUEST_TYPE_ID;