Skip to content

Commit b26a7e5

Browse files
committed
Rename ID_V2 to UID
1 parent 8cbce5c commit b26a7e5

File tree

3 files changed

+10
-10
lines changed

3 files changed

+10
-10
lines changed

dev/tests/api-functional/testsuite/Magento/GraphQl/ConfigurableProduct/AddConfigurableProductToCartSingleMutationTest.php

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ public function testAddConfigurableProductToCart()
4343
$attributeId = (int) $product['configurable_options'][0]['attribute_id'];
4444
$valueIndex = $product['configurable_options'][0]['values'][1]['value_index'];
4545

46-
$selectedConfigurableOptionsQuery = $this->generateSuperAttributesIdV2Query($attributeId, $valueIndex);
46+
$selectedConfigurableOptionsQuery = $this->generateSuperAttributesUIDQuery($attributeId, $valueIndex);
4747
$maskedQuoteId = $this->getMaskedQuoteIdByReservedOrderId->execute('test_order_1');
4848

4949
$query = $this->getQuery(
@@ -68,13 +68,13 @@ public function testAddConfigurableProductToCart()
6868
}
6969

7070
/**
71-
* Generates Id_v2 for super configurable product super attributes
71+
* Generates UID for super configurable product super attributes
7272
*
7373
* @param int $attributeId
7474
* @param int $valueIndex
7575
* @return string
7676
*/
77-
private function generateSuperAttributesIdV2Query(int $attributeId, int $valueIndex): string
77+
private function generateSuperAttributesUIDQuery(int $attributeId, int $valueIndex): string
7878
{
7979
return 'selected_options: ["' . base64_encode("configurable/$attributeId/$valueIndex") . '"]';
8080
}
@@ -89,7 +89,7 @@ public function testAddConfigurableProductWithWrongSuperAttributes()
8989
$quantity = 2;
9090
$parentSku = $product['sku'];
9191

92-
$selectedConfigurableOptionsQuery = $this->generateSuperAttributesIdV2Query(0, 0);
92+
$selectedConfigurableOptionsQuery = $this->generateSuperAttributesUIDQuery(0, 0);
9393
$maskedQuoteId = $this->getMaskedQuoteIdByReservedOrderId->execute('test_order_1');
9494

9595
$query = $this->getQuery(
@@ -118,7 +118,7 @@ public function testAddProductIfQuantityIsNotAvailable()
118118
$attributeId = (int) $product['configurable_options'][0]['attribute_id'];
119119
$valueIndex = $product['configurable_options'][0]['values'][1]['value_index'];
120120

121-
$selectedConfigurableOptionsQuery = $this->generateSuperAttributesIdV2Query($attributeId, $valueIndex);
121+
$selectedConfigurableOptionsQuery = $this->generateSuperAttributesUIDQuery($attributeId, $valueIndex);
122122
$maskedQuoteId = $this->getMaskedQuoteIdByReservedOrderId->execute('test_order_1');
123123

124124
$query = $this->getQuery(
@@ -171,7 +171,7 @@ public function testOutOfStockVariationToCart()
171171
$valueIndex = $product['configurable_options'][0]['values'][0]['value_index'];
172172
$parentSku = $product['sku'];
173173

174-
$configurableOptionsQuery = $this->generateSuperAttributesIdV2Query($attributeId, $valueIndex);
174+
$configurableOptionsQuery = $this->generateSuperAttributesUIDQuery($attributeId, $valueIndex);
175175
$maskedQuoteId = $this->getMaskedQuoteIdByReservedOrderId->execute('test_order_1');
176176

177177
$query = $this->getQuery(

dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/AddDownloadableProductToCartSingleMutationTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ private function getProductsLinks(string $sku) : array
132132
}
133133

134134
/**
135-
* Generates Id_v2 for downloadable links
135+
* Generates UID for downloadable links
136136
*
137137
* @param int $linkId
138138
* @return string

dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/GetCustomOptionsWithUIDForQueryBySku.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
use Magento\Catalog\Api\ProductCustomOptionRepositoryInterface;
1111

1212
/**
13-
* Generate an array with test values for customizable options with encoded id_v2 value
13+
* Generate an array with test values for customizable options with UID
1414
*/
1515
class GetCustomOptionsWithUIDForQueryBySku
1616
{
@@ -83,7 +83,7 @@ public function execute(string $sku): array
8383
}
8484

8585
/**
86-
* Returns id_v2 of the selected custom option
86+
* Returns UID of the selected custom option
8787
*
8888
* @param int $optionId
8989
* @param int $optionValueId
@@ -95,7 +95,7 @@ private function encodeSelectedOption(int $optionId, int $optionValueId): string
9595
}
9696

9797
/**
98-
* Returns id_v2 of the entered custom option
98+
* Returns UID of the entered custom option
9999
*
100100
* @param int $optionId
101101
* @return string

0 commit comments

Comments
 (0)