ACP2E-1918: Cannot create more than 1 Credit Memo for $0 Order

Author: viktym

app/code/Magento/Checkout/Test/Fixture/SetPaymentMethod.php

@@ -38,17 +38,21 @@ public function __construct(
 
     /**
      * {@inheritdoc}
-     * @param array $data Parameters
+     * @param array $data Parameters. Same format as SetPaymentMethod::DEFAULT_DATA.
      * <pre>
      *    $data = [
      *      'cart_id' => (int) Cart ID. Required
      *      'method' => (array) Payment method. Optional
      *    ]
      * </pre>
+     * Fields structure:
+     * - $data['method']: can be supplied in following formats:
+     *      - array ["method" => "checkmo", "po_number" => null, "additional_data" => null]
+     *      - string "checkmo"
      */
     public function apply(array $data = []): ?DataObject
     {
-        $data = array_merge(self::DEFAULT_DATA, $data);
+        $data = $this->prepareData($data);
         $service = $this->serviceFactory->create(PaymentMethodManagementInterface::class, 'set');
         $service->execute(
             [
@@ -59,4 +63,19 @@ public function apply(array $data = []): ?DataObject
 
         return null;
     }
+
+    /**
+     * Prepare payment data
+     *
+     * @param array $data
+     * @return array
+     */
+    private function prepareData(array $data): array
+    {
+        if (is_string($data['method'])) {
+            $data['method'] = ['method' => $data['method']];
+        }
+
+        return array_merge(self::DEFAULT_DATA, $data);
+    }
 }

app/code/Magento/Sales/Model/Order.php

@@ -769,10 +769,8 @@ private function canCreditmemoForZeroTotalRefunded($totalRefunded)
      */
     private function canCreditmemoForZeroTotal($totalRefunded)
     {
-        foreach ($this->getAllItems() as $orderItem) {
-            if ($this->creditmemoValidator->canRefundItem($orderItem)) {
-                return true;
-            }
+        if ($this->areThereRefundableItems()) {
+            return true;
         }
 
         $totalPaid = $this->getTotalPaid();
@@ -792,6 +790,22 @@ private function canCreditmemoForZeroTotal($totalRefunded)
         return true;
     }
 
+    /**
+     * Check if there are order items available for refund.
+     *
+     * @return bool
+     */
+    private function areThereRefundableItems(): bool
+    {
+        foreach ($this->getAllItems() as $orderItem) {
+            if ($this->creditmemoValidator->canRefundItem($orderItem)) {
+                return true;
+            }
+        }
+
+        return false;
+    }
+
     /**
      * Retrieve order hold availability
      *

app/code/Magento/Sales/Test/Fixture/Creditmemo.php

@@ -62,10 +62,10 @@ public function __construct(
      * @param array $data Parameters. Same format as Creditmemo::DEFAULT_DATA.
      * Fields structure fields:
      * - $data['items']: can be supplied in following formats:
-     *      - array of arrays [{"sku":"$product1.sku$","qty":1}, {"sku":"$product2.sku$","qty":1}]
-     *      - array of arrays [{"order_item_id":"$oItem1.sku$","qty":1}, {"order_item_id":"$oItem2.sku$","qty":1}]
-     *      - array of arrays [{"product_id":"$product1.id$","qty":1}, {"product_id":"$product2.id$","qty":1}]
-     *      - array of arrays [{"quote_item_id":"$qItem1.id$","qty":1}, {"quote_item_id":"$qItem2.id$","qty":1}]
+     *      - array of arrays [["sku":"$product1.sku$","qty":1], ["sku":"$product2.sku$","qty":1]]
+     *      - array of arrays [["order_item_id":"$oItem1.sku$","qty":1], ["order_item_id":"$oItem2.sku$","qty":1]]
+     *      - array of arrays [["product_id":"$product1.id$","qty":1], ["product_id":"$product2.id$","qty":1]]
+     *      - array of arrays [["quote_item_id":"$qItem1.id$","qty":1], ["quote_item_id":"$qItem2.id$","qty":1]]
      *      - array of SKUs ["$product1.sku$", "$product2.sku$"]
      *      - array of order items IDs ["$oItem1.id$", "$oItem2.id$"]
      *      - array of product instances ["$product1$", "$product2$"]

app/code/Magento/Sales/Test/Unit/Model/OrderTest.php

@@ -28,7 +28,7 @@
 use Magento\Sales\Model\ResourceModel\Order\Collection as OrderCollection;
 use Magento\Sales\Model\ResourceModel\Order\CollectionFactory as OrderCollectionFactory;
 use Magento\Sales\Model\ResourceModel\Order\Invoice\Collection as OrderInvoiceCollection;
-use Magento\Sales\Model\ResourceModel\Order\Item;
+use Magento\Sales\Model\Order\Item;
 use Magento\Sales\Model\ResourceModel\Order\Item\Collection as OrderItemCollection;
 use Magento\Sales\Model\ResourceModel\Order\Item\CollectionFactory as OrderItemCollectionFactory;
 use Magento\Sales\Model\ResourceModel\Order\Payment;
@@ -153,16 +153,6 @@ protected function setUp(): void
             ['create']
         );
         $this->item = $this->getMockBuilder(Item::class)
-            ->addMethods(
-                [
-                    'isDeleted',
-                    'getQtyToInvoice',
-                    'getParentItemId',
-                    'getQuoteItemId',
-                    'getLockedDoInvoice',
-                    'getProductId'
-                ]
-            )
             ->disableOriginalConstructor()
             ->getMock();
         $this->salesOrderCollectionMock = $this->getMockBuilder(

dev/tests/integration/testsuite/Magento/Sales/Model/OrderTest.php

@@ -43,7 +43,7 @@ protected function setUp(): void
     }
 
     /**
-     * Tests that multiple credit memos can be created for zero total order.
+     * Tests that multiple credit memos can be created for zero total order if not all items are refunded yet
      */
     #[
         Config('carriers/freeshipping/active', '1', 'store', 'default'),
@@ -71,7 +71,7 @@ protected function setUp(): void
             SetDeliveryMethodFixture::class,
             ['cart_id' => '$cart.id$', 'carrier_code' => 'freeshipping', 'method_code' => 'freeshipping']
         ),
-        DataFixture(SetPaymentMethodFixture::class, ['cart_id' => '$cart.id$', 'method' => ['method' => 'free']]),
+        DataFixture(SetPaymentMethodFixture::class, ['cart_id' => '$cart.id$', 'method' => 'free']),
         DataFixture(PlaceOrderFixture::class, ['cart_id' => '$cart.id$'], 'order'),
         DataFixture(InvoiceFixture::class, ['order_id' => '$order.id$'], 'invoice'),
         DataFixture(

dev/tests/integration/testsuite/Magento/Sales/_files/creditmemo_with_grouped_product.php

@@ -5,6 +5,7 @@
  */
 declare(strict_types=1);
 
+use Magento\Sales\Model\InvoiceOrder;
 use Magento\Sales\Model\Order;
 use Magento\Sales\Model\Order\Creditmemo;
 use Magento\Sales\Model\Order\Creditmemo\Item;
@@ -20,6 +21,7 @@
 /** @var Order $order */
 $order = $objectManager->create(Order::class);
 $order->loadByIncrementId('100000002');
+$objectManager->get(InvoiceOrder::class)->execute($order->getId());
 $creditmemo = $creditmemoFactory->createByOrder($order, $order->getData());
 $creditmemo->setOrder($order);
 $creditmemo->setState(Creditmemo::STATE_OPEN);