Skip to content

Commit b396529

Browse files
pradeep.rauthanpradeep.rauthan
authored andcommitted
MC-42704: Admin Checkout validation bug-
Updated JS for code refactoring
1 parent 4c740ca commit b396529

File tree

1 file changed

+9
-33
lines changed
  • app/code/Magento/Sales/view/adminhtml/web/order/create

1 file changed

+9
-33
lines changed

app/code/Magento/Sales/view/adminhtml/web/order/create/scripts.js

Lines changed: 9 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -245,8 +245,7 @@ define([
245245
type,
246246
name,
247247
data,
248-
resetShipping = false,
249-
resetSelectedBillingAddress = false;
248+
resetShipping = false;
250249

251250
if (!matchRes) {
252251
return;
@@ -265,7 +264,6 @@ define([
265264
if (type === 'billing' && this.shippingAsBilling) {
266265
this.syncAddressField(this.shippingAddressContainer, field.name, field);
267266
resetShipping = true;
268-
resetSelectedBillingAddress = true;
269267
}
270268

271269
if (type === 'shipping' && !this.shippingAsBilling) {
@@ -278,15 +276,16 @@ define([
278276

279277
if (resetShipping) {
280278
data['reset_shipping'] = true;
281-
282-
if(name !== 'customer_address_id' && this.selectAddressEvent === false) {
283-
this.clearSelected('order-shipping_address_customer_address_id');
284-
}
285279
}
286280

287-
if (resetSelectedBillingAddress) {
288-
if(name !== 'customer_address_id' && this.selectAddressEvent === false) {
289-
this.clearSelected('order-billing_address_customer_address_id');
281+
if (this.selectAddressEvent === false) {
282+
if (this.shippingAsBilling) {
283+
$('order-shipping_address_customer_address_id').value = '';
284+
}
285+
// customer_address_id can not be set to blank, if changed to other saved addresses from dropdown list
286+
// for both billing & shipping while no change made in other address fields
287+
if (name !== 'customer_address_id') {
288+
$('order-' + type + '_address_customer_address_id').value = '';
290289
}
291290
}
292291

@@ -296,12 +295,6 @@ define([
296295
if (name === 'customer_address_id') {
297296
data['order[' + type + '_address][customer_address_id]'] =
298297
$('order-' + type + '_address_customer_address_id').value;
299-
300-
// Clear previously selected shipping address id in order to treat it as new from frontend
301-
// dropdown(Select from existing customer addresses) change event
302-
if(this.shippingAsBilling) {
303-
this.clearSelected('order-shipping_address_customer_address_id');
304-
}
305298
}
306299

307300
if (name === 'country_id' && this.selectAddressEvent === false) {
@@ -321,23 +314,6 @@ define([
321314
}
322315
},
323316

324-
/**
325-
* Deselect customer address selected value.
326-
*
327-
* @param {String} id - field ID
328-
*/
329-
clearSelected: function(id){
330-
var element = $(id);
331-
if(typeof element !== 'undefined' && element !== null) {
332-
if(element.value){
333-
var elem = element.options;
334-
for(var i = 0; i < elem.length; i++){
335-
elem[i].selected = false;
336-
}
337-
}
338-
}
339-
},
340-
341317
/**
342318
* Set address container form field value.
343319
*

0 commit comments

Comments
 (0)