Skip to content

Commit b6214ff

Browse files
committed
AC-14884 : Added my fixes
1 parent 76e2a92 commit b6214ff

File tree

2 files changed

+1
-4
lines changed

2 files changed

+1
-4
lines changed

app/code/Magento/SalesRule/Model/Rule/Condition/Product/Subselect.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -156,9 +156,6 @@ public function asHtml()
156156
public function validate(AbstractModel $model)
157157
{
158158
$subSelectConditionsFlag = true;
159-
if (!$this->getConditions()) {
160-
return false;
161-
}
162159
$attr = $this->getAttribute();
163160
$total = 0;
164161
$isMultiShipping = (bool) $model->getQuote()->getIsMultiShipping();

app/code/Magento/SalesRule/Test/Unit/Model/Rule/Condition/Product/SubselectTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -413,7 +413,7 @@ public static function dataProviderForFixedBundleProduct(): array
413413
'valueParsed' => 100
414414
],
415415
false,
416-
false
416+
true
417417
],
418418
'validate true for bundle product
419419
data with conditions for attribute base_row_total w/o multi shipping' =>

0 commit comments

Comments
 (0)