fixed schedule currency_rates_update cron job not working

brunoroeder · brunoroeder · commit b63fd5e10d2f · 2019-09-14T12:06:17.000-03:00
diff --git a/app/code/Magento/Directory/Model/Observer.php b/app/code/Magento/Directory/Model/Observer.php
@@ -83,12 +83,11 @@ public function __construct(
     }
 
     /**
-     * @param mixed $schedule
      * @return void
      * @throws \Exception
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
-    public function scheduledUpdateCurrencyRates($schedule)
+    public function scheduledUpdateCurrencyRates()
     {
         $importWarnings = [];
         if (!$this->_scopeConfig->getValue(
diff --git a/app/code/Magento/Directory/etc/crontab.xml b/app/code/Magento/Directory/etc/crontab.xml
@@ -7,6 +7,8 @@
 -->
 <config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:module:Magento_Cron:etc/crontab.xsd">
     <group id="default">
-        <job name="currency_rates_update" instance="Magento\Directory\Model\Observer" method="scheduledUpdateCurrencyRates" />
+        <job name="currency_rates_update" instance="Magento\Directory\Model\Observer" method="scheduledUpdateCurrencyRates">
+            <config_path>crontab/default/jobs/currency_rates_update/schedule/cron_expr</config_path>
+        </job>
     </group>
 </config>

Original file line number	Diff line number	Diff line change
`@@ -83,12 +83,11 @@ public function __construct(`
`83`	`83`	`}`
`84`	`84`
`85`	`85`	`/**`
`86`		`- * @param mixed $schedule`
`87`	`86`	`* @return void`
`88`	`87`	`* @throws \Exception`
`89`	`88`	`* @SuppressWarnings(PHPMD.UnusedFormalParameter)`
`90`	`89`	`*/`
`91`		`- public function scheduledUpdateCurrencyRates($schedule)`
	`90`	`+ public function scheduledUpdateCurrencyRates()`
`92`	`91`	`{`
`93`	`92`	`$importWarnings = [];`
`94`	`93`	`if (!$this->_scopeConfig->getValue(`