GraphQl-463: Query category for disabled catalog with products returns the product count

XxXgeoXxX · XxXgeoXxX · commit b676132f2a1c · 2019-05-10T09:00:17.000+03:00
diff --git a/app/code/Magento/CatalogGraphQl/Model/Resolver/Products/DataProvider/CategoryTree.php b/app/code/Magento/CatalogGraphQl/Model/Resolver/Products/DataProvider/CategoryTree.php
@@ -85,7 +85,7 @@ public function __construct(
     public function getTree(ResolveInfo $resolveInfo, int $rootCategoryId): \Iterator
     {
         $categoryQuery = $resolveInfo->fieldNodes[0];
-        if ($this->isCategoryActive($rootCategoryId) == false) {
+        if ($this->isCategoryActive($rootCategoryId) === false) {
             throw new GraphQlNoSuchEntityException(__('Category doesn\'t exist'));
         }
 
@@ -155,7 +155,7 @@ private function joinAttributesRecursively(Collection $collection, FieldNode $fi
      *
      * @param int $rootCategoryId
      * @return bool
-     * @throws \Exception
+     * @throws \Magento\Framework\Exception\LocalizedException
      */
     private function isCategoryActive(int $rootCategoryId) : bool
     {

Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,7 @@ public function __construct(`
`85`	`85`	`public function getTree(ResolveInfo $resolveInfo, int $rootCategoryId): \Iterator`
`86`	`86`	`{`
`87`	`87`	`$categoryQuery = $resolveInfo->fieldNodes[0];`
`88`		`- if ($this->isCategoryActive($rootCategoryId) == false) {`
	`88`	`+ if ($this->isCategoryActive($rootCategoryId) === false) {`
`89`	`89`	`throw new GraphQlNoSuchEntityException(__('Category doesn\'t exist'));`
`90`	`90`	`}`
`91`	`91`
`@@ -155,7 +155,7 @@ private function joinAttributesRecursively(Collection $collection, FieldNode $fi`
`155`	`155`	`*`
`156`	`156`	`* @param int $rootCategoryId`
`157`	`157`	`* @return bool`
`158`		`- * @throws \Exception`
	`158`	`+ * @throws \Magento\Framework\Exception\LocalizedException`
`159`	`159`	`*/`
`160`	`160`	`private function isCategoryActive(int $rootCategoryId) : bool`
`161`	`161`	`{`