ENGCOM-5779: #24441 : Minicart height calculated incorrectly when child items contain margins #24451

magento-engcom-team · magento-engcom-team · commit b6b8efbf4b9e · 2019-09-04T14:57:25.000-05:00
- Merge Pull Request #24451 from konarshankar07/magento2:minicart-height-calculate-incorrect-24441 - Merged commits: 1. 25a90fb
diff --git a/app/code/Magento/Checkout/view/frontend/web/js/sidebar.js b/app/code/Magento/Checkout/view/frontend/web/js/sidebar.js
@@ -347,7 +347,7 @@ define([
                 if ($(this).find('.options').length > 0) {
                     $(this).collapsible();
                 }
-                outerHeight = $(this).outerHeight();
+                outerHeight = $(this).outerHeight(true);
 
                 if (counter-- > 0) {
                     height += outerHeight;

Original file line number	Diff line number	Diff line change
`@@ -347,7 +347,7 @@ define([`
`347`	`347`	`if ($(this).find('.options').length > 0) {`
`348`	`348`	`$(this).collapsible();`
`349`	`349`	`}`
`350`		`- outerHeight = $(this).outerHeight();`
	`350`	`+ outerHeight = $(this).outerHeight(true);`
`351`	`351`
`352`	`352`	`if (counter-- > 0) {`
`353`	`353`	`height += outerHeight;`