Improve performance of DataObject magic calls and addData()

The magic calls from the DataObject are being called over a 100k when there is no block_cache available and depending on the page often thousands of times when all block_cache is available.

The small change for addData() is just included because its a tiny optimization and prevents a bug from happening. When a $value is an array the original call to setData would override the internal $_data array, this is not expected behavior and just setting it directly to $_data is faster anyway.

The other change is in the __call magic method and the _underscore function and the change is quite radical.
Since this method can be called so often, we want to prevent further function calls if possible. Functional calls are normally not that expensive, but will become more expensive if you use this extensively (thousands of even hundred of thousands extra calls):

These are my own benchmarks based on a local environment with opcache and with PROD mode. 

HOMEPAGE transaction
All cache enabled except for FPC (__call is called 975 times): 4.318307ms -> 1.469747ms
All cache enabled except for FPC + Block_html  (__call is called 100379 times): 385.36412ms -> 88.412914ms

PLP transaction:
All cache enabled except for FPC  (__call is called 4628 times): 19.625463ms -> 5.754514ms
All cache enabled except for FPC + Block_html (__call is called 112591 times): 404.84066ms -> 99.390374ms

Now this PR also skips some checks. It assumes if a $method call start with 'g' it will be for 'get' for example, this is done in my PR to get the most optimal performance result but might not be preferred. I also removed an index check with $args[1] for the setter since it isn't used anywhere, but might also be something we would want to change.

Author: igorwulff

lib/internal/Magento/Framework/DataObject.php

@@ -57,7 +57,7 @@ public function addData(array $arr)
         }
 
         foreach ($arr as $index => $value) {
-            $this->setData($index, $value);
+            $this->_data[$key] = $value;
         }
         return $this;
     }
@@ -387,22 +387,26 @@ public function toString($format = '')
      */
     public function __call($method, $args)
     {
-        switch (substr((string)$method, 0, 3)) {
-            case 'get':
-                $key = $this->_underscore(substr($method, 3));
-                $index = isset($args[0]) ? $args[0] : null;
-                return $this->getData($key, $index);
-            case 'set':
-                $key = $this->_underscore(substr($method, 3));
-                $value = isset($args[0]) ? $args[0] : null;
-                return $this->setData($key, $value);
-            case 'uns':
-                $key = $this->_underscore(substr($method, 3));
-                return $this->unsetData($key);
-            case 'has':
-                $key = $this->_underscore(substr($method, 3));
-                return isset($this->_data[$key]);
+        switch($method[0]) {
+            case 'g':
+                return $this->_data[
+                    self::$_underscoreCache[$method] ?? $this->_underscore($method)
+                ] ?? null;
+            case 's':
+                $this->_data[
+                    self::$_underscoreCache[$method] ?? $this->_underscore($method)
+                ] = $args[0] ?? null;
+                return $this;
+            case 'u':
+                return $this->unsetData(self::$_underscoreCache[$method] ?? $this->_underscore($method));
+            case 'h':
+                return isset(
+                    $this->_data[
+                        self::$_underscoreCache[$method] ?? $this->_underscore($method)
+                    ]
+                );
         }
+        
         throw new \Magento\Framework\Exception\LocalizedException(
             new \Magento\Framework\Phrase('Invalid method %1::%2', [get_class($this), $method])
         );
@@ -435,7 +439,17 @@ protected function _underscore($name)
         if (isset(self::$_underscoreCache[$name])) {
             return self::$_underscoreCache[$name];
         }
-        $result = strtolower(trim(preg_replace('/([A-Z]|[0-9]+)/', "_$1", $name), '_'));
+        
+        $result = strtolower(
+            trim(
+                preg_replace(
+                    '/([A-Z]|[0-9])/', "_$1",
+                    lcfirst(substr($name, 3))
+                ),
+                '_'
+            )
+        );
+        
         self::$_underscoreCache[$name] = $result;
         return $result;
     }