Skip to content

Commit b837d29

Browse files
committed
MAGETWO-99830: Redundant URL rewrites regeneration when products are added to or removed from a category
1 parent 73fe917 commit b837d29

File tree

2 files changed

+9
-3
lines changed

2 files changed

+9
-3
lines changed

dev/tests/integration/testsuite/Magento/CatalogUrlRewrite/Observer/UrlRewriteHandlerTest.php

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -99,9 +99,14 @@ public function testGenerateProductUrlRewrites2()
9999
$category->setAffectedProductIds([$product1->getId(), $product2->getId()]);
100100
$category->setAnchorsAbove(false);
101101
$generatedUrls = $this->handler->generateProductUrlRewrites($category);
102-
$actual = array_values(array_map(function (UrlRewrite $urlRewrite) {
103-
return $urlRewrite->getRequestPath();
104-
}, $generatedUrls));
102+
$actual = array_values(
103+
array_map(
104+
function (UrlRewrite $urlRewrite) {
105+
return $urlRewrite->getRequestPath();
106+
},
107+
$generatedUrls
108+
)
109+
);
105110

106111
$expected = [
107112
'simple-product.html',

dev/tests/integration/testsuite/Magento/CatalogUrlRewrite/_files/category_with_products_rollback.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
$productRepository->delete($product);
1919
} catch (\Magento\Framework\Exception\NoSuchEntityException $e) {
2020
//Product already removed
21+
continue;
2122
}
2223
}
2324

0 commit comments

Comments
 (0)