Detect plugin in namespace

Signed-off-by: Denis Kopylov <[email protected]>

Author: Den4ik

app/code/Magento/Catalog/Plugin/CategoryAuthorization.php

@@ -12,12 +12,11 @@
 use Magento\Catalog\Api\CategoryRepositoryInterface;
 use Magento\Catalog\Model\Category\Authorization;
 use Magento\Framework\Exception\LocalizedException;
-use Magento\Framework\Interception\PluginInterface;
 
 /**
  * Perform additional authorization for category operations.
  */
-class CategoryAuthorization implements PluginInterface
+class CategoryAuthorization
 {
     /**
      * @var Authorization

app/code/Magento/Catalog/Plugin/ProductAuthorization.php

@@ -12,12 +12,11 @@
 use Magento\Catalog\Api\ProductRepositoryInterface;
 use Magento\Catalog\Model\Product\Authorization;
 use Magento\Framework\Exception\LocalizedException;
-use Magento\Framework\Interception\PluginInterface;
 
 /**
  * Perform additional authorization for product operations.
  */
-class ProductAuthorization implements PluginInterface
+class ProductAuthorization
 {
     /**
      * @var Authorization

app/code/Magento/Catalog/Plugin/RemoveImagesFromGalleryAfterRemovingProduct.php

@@ -12,12 +12,11 @@
 use Magento\Catalog\Api\ProductRepositoryInterface;
 use Magento\Catalog\Model\Product\Gallery\ReadHandler;
 use Magento\Catalog\Model\ResourceModel\Product\Gallery;
-use Magento\Framework\Interception\PluginInterface;
 
 /**
  * Responsible for deleting images from media gallery after deleting product
  */
-class RemoveImagesFromGalleryAfterRemovingProduct implements PluginInterface
+class RemoveImagesFromGalleryAfterRemovingProduct
 {
     /**
      * @var Gallery

dev/tests/static/framework/Magento/CodeMessDetector/Rule/UnusedCode/UnusedFormalParameter.php

@@ -40,8 +40,7 @@ private function removeVariablesUsedInPlugins(AbstractNode $node)
         if ($node instanceof MethodNode) {
             /** @var ClassNode $classNode */
             $classNode = $node->getParentType();
-            $implementInterfaces = class_implements($classNode->getFullQualifiedName());
-            if (array_key_exists(PluginInterface::class, $implementInterfaces)) {
+            if ($this->isPluginClass($classNode->getNamespaceName())) {
                 /**
                  * Around and After plugins has 2 required params $subject and $proceed or $result
                  * that should be ignored
@@ -103,4 +102,14 @@ private function removeVariablesByCount(MethodNode $node, int $countOfRemovingVa
             unset($this->nodes[$methodParameter->getName()]);
         }
     }
+
+    /**
+     * Check if namespace contain "Plugin"
+     * @param $class
+     * @return bool
+     */
+    private function isPluginClass($class): bool
+    {
+        return (stripos($class, 'Plugin') !== false);
+    }
 }