ACP2E-175: Internal error when adding a disabled product to cart using GraphQl

Author: dhorytskyi

app/code/Magento/CatalogGraphQl/Plugin/AvailableProductsFilter.php

@@ -41,8 +41,14 @@ public function __construct(ContextFactoryInterface $contextFactory)
      * @throws NoSuchEntityException
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
-    public function afterGet(ProductRepositoryInterface $subject, ProductInterface $result, $sku, $editMode = false, $storeId = null, $forceReload = false): ProductInterface
-    {
+    public function afterGet(
+        ProductRepositoryInterface $subject,
+        ProductInterface $result,
+        $sku,
+        $editMode = false,
+        $storeId = null,
+        $forceReload = false
+    ): ProductInterface {
         if (ProductStatus::STATUS_ENABLED !== (int) $result->getStatus()) {
             throw new NoSuchEntityException(
                 __("The product that was requested doesn't exist. Verify the product and try again.")

app/code/Magento/Wishlist/Model/Wishlist/AddProductsToWishlist.php

@@ -117,9 +117,6 @@ private function addItemToWishlist(Wishlist $wishlist, WishlistItem $wishlistIte
             if ((int)$wishlistItem->getQuantity() === 0) {
                 throw new LocalizedException(__("The quantity of a wish list item cannot be 0"));
             }
-            if ($product->getStatus() == Status::STATUS_DISABLED) {
-                throw new LocalizedException(__("The product is disabled"));
-            }
             $options = $this->buyRequestBuilder->build($wishlistItem, (int) $product->getId());
             $result = $wishlist->addNewItem($product, $options);
 

dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/Guest/AddSimpleProductToCartTest.php

@@ -196,8 +196,7 @@ public function testAddDisabledProductToCart(): void
 
         $this->expectException(ResponseContainsErrorsException::class);
         $this->expectExceptionMessage(
-            'Could not add the product with SKU ' . $sku . ' to the shopping cart: ' .
-            'Product that you are trying to add is not available.'
+            'GraphQL response contains errors: Could not find a product with SKU "' . $sku . '"'
         );
 
         $this->graphQlMutation($query);

dev/tests/api-functional/testsuite/Magento/GraphQl/Wishlist/CustomerWishlistTest.php

@@ -261,7 +261,7 @@ public function testAddProductToWishlistWithDisabledProduct()
             $addToWishlistResponse['addProductsToWishlist']['wishlist']['items_count'],
             'Count is greater than 0'
         );
-        $message = 'The product is disabled';
+        $message = 'Could not find a product with SKU "' . $sku . '"';
         $this->assertEquals(
             $message,
             $addToWishlistResponse['addProductsToWishlist']['user_errors'][0]['message']