Introduce strict_types

Author: lbajsarowicz

app/code/Magento/Version/Controller/Index/Index.php

@@ -4,12 +4,13 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
 
 namespace Magento\Version\Controller\Index;
 
-use Magento\Framework\App\Action\HttpGetActionInterface as HttpGetActionInterface;
 use Magento\Framework\App\Action\Action;
 use Magento\Framework\App\Action\Context;
+use Magento\Framework\App\Action\HttpGetActionInterface as HttpGetActionInterface;
 use Magento\Framework\App\ProductMetadataInterface;
 
 /**
@@ -40,7 +41,7 @@ public function __construct(Context $context, ProductMetadataInterface $productM
      *
      * @return void
      */
-    public function execute()
+    public function execute(): void
     {
         $version = $this->productMetadata->getVersion();
         $versionParts = explode('.', $version);
@@ -61,7 +62,7 @@ public function execute()
      * @param string $fullVersion
      * @return bool
      */
-    private function isGitBasedInstallation($fullVersion)
+    private function isGitBasedInstallation($fullVersion): bool
     {
         return 0 === strpos($fullVersion, self::DEV_PREFIX);
     }

app/code/Magento/Version/Test/Unit/Controller/Index/IndexTest.php

@@ -7,11 +7,11 @@
 
 namespace Magento\Version\Test\Unit\Controller\Index;
 
-use Magento\Version\Controller\Index\Index as VersionIndex;
 use Magento\Framework\App\Action\Context;
 use Magento\Framework\App\ProductMetadataInterface;
 use Magento\Framework\App\ResponseInterface;
 use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
+use Magento\Version\Controller\Index\Index as VersionIndex;
 use PHPUnit\Framework\TestCase;
 
 class IndexTest extends TestCase
@@ -73,7 +73,7 @@ protected function setUp()
     /**
      * Git Base version does not return information about version
      */
-    public function testGitBasedInstallationDoesNotReturnVersion()
+    public function testGitBasedInstallationDoesNotReturnVersion(): void
     {
         $this->productMetadataMock->expects($this->any())
             ->method('getVersion')
@@ -88,7 +88,7 @@ public function testGitBasedInstallationDoesNotReturnVersion()
     /**
      * Magento Community returns information about major and minor version of product
      */
-    public function testCommunityVersionDisplaysMajorMinorVersionAndEditionName()
+    public function testCommunityVersionDisplaysMajorMinorVersionAndEditionName(): void
     {
         $this->productMetadataMock->expects($this->any())->method('getVersion')->willReturn('2.3.3');
         $this->productMetadataMock->expects($this->any())->method('getEdition')->willReturn('Community');