ignored factories of external adapters

akaplya · akaplya · commit bbb95551726f · 2020-02-21T14:05:34.000-06:00
diff --git a/dev/tests/static/testsuite/Magento/Test/Php/_files/phpstan/blacklist/common.txt b/dev/tests/static/testsuite/Magento/Test/Php/_files/phpstan/blacklist/common.txt
@@ -14,3 +14,5 @@ dev/tests/api-functional/testsuite/Magento/Customer/Api/AddressRepositoryTest.ph
 dev/tests/api-functional/testsuite/Magento/Framework/Model/Entity/HydratorTest.php
 dev/tests/api-functional/testsuite/Magento/Integration/Model/AdminTokenServiceTest.php
 dev/tests/api-functional/testsuite/Magento/Integration/Model/CustomerTokenServiceTest.php
+lib/internal/Magento/Framework/Storage/AdapterFactory/AwsS3Factory.php
+lib/internal/Magento/Framework/Storage/AdapterFactory/AzureFactory.php
diff --git a/lib/internal/Magento/Framework/Storage/AdapterFactory/AwsS3Factory.php b/lib/internal/Magento/Framework/Storage/AdapterFactory/AwsS3Factory.php
@@ -20,7 +20,6 @@ class AwsS3Factory implements AdapterFactoryInterface
      */
     public function create(array $options): AdapterInterface
     {
-        // phpstan:ignore
         if (empty($options['client']) || empty($options['bucket'])) {
             throw new InvalidStorageConfigurationException(
                 "Can't create AWS S3 adapter: required 'client' and/or 'bucket' options are absent"
diff --git a/lib/internal/Magento/Framework/Storage/AdapterFactory/AzureFactory.php b/lib/internal/Magento/Framework/Storage/AdapterFactory/AzureFactory.php
@@ -20,7 +20,6 @@ class AzureFactory implements AdapterFactoryInterface
      */
     public function create(array $options): AdapterInterface
     {
-        // phpstan:ignore
         if (empty($options['connection_string']) || empty($options['container_name'])) {
             throw new InvalidStorageConfigurationException(
                 "Can't create Azure Blob storage adapter: " .

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,6 @@ class AwsS3Factory implements AdapterFactoryInterface`
`20`	`20`	`*/`
`21`	`21`	`public function create(array $options): AdapterInterface`
`22`	`22`	`{`
`23`		`- // phpstan:ignore`
`24`	`23`	`if (empty($options['client']) \|\| empty($options['bucket'])) {`
`25`	`24`	`throw new InvalidStorageConfigurationException(`
`26`	`25`	`"Can't create AWS S3 adapter: required 'client' and/or 'bucket' options are absent"`
Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,6 @@ class AzureFactory implements AdapterFactoryInterface`
`20`	`20`	`*/`
`21`	`21`	`public function create(array $options): AdapterInterface`
`22`	`22`	`{`
`23`		`- // phpstan:ignore`
`24`	`23`	`if (empty($options['connection_string']) \|\| empty($options['container_name'])) {`
`25`	`24`	`throw new InvalidStorageConfigurationException(`
`26`	`25`	`"Can't create Azure Blob storage adapter: " .`