Skip to content

Commit bbfb82b

Browse files
committed
Merge remote-tracking branch 'origin/webapi_test' into phpunit10
2 parents 95d676c + 3769e3a commit bbfb82b

24 files changed

+133
-306
lines changed

dev/tests/api-functional/phpunit_graphql.xml.dist

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,6 @@
5858
<!-- Path to config file (default is config/allure.config.php) -->
5959
<parameter name="config" value="allure/allure.config.php" />
6060
</bootstrap>
61-
<bootstrap class="Magento\TestFramework\Event\PhpUnitExtension"/>
61+
<bootstrap class="Magento\TestFramework\Event\Subscribers"/>
6262
</extensions>
6363
</phpunit>

dev/tests/api-functional/phpunit_rest.xml.dist

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,6 @@
6262
<!-- Path to config file (default is config/allure.config.php) -->
6363
<parameter name="config" value="allure/allure.config.php" />
6464
</bootstrap>
65-
<bootstrap class="Magento\TestFramework\Event\PhpUnitExtension"/>
65+
<bootstrap class="Magento\TestFramework\Event\Subscribers"/>
6666
</extensions>
6767
</phpunit>

dev/tests/api-functional/phpunit_soap.xml.dist

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,5 +61,6 @@
6161
<!-- Path to config file (default is config/allure.config.php) -->
6262
<parameter name="config" value="allure/allure.config.php" />
6363
</bootstrap>
64+
<bootstrap class="Magento\TestFramework\Event\Subscribers"/>
6465
</extensions>
6566
</phpunit>

dev/tests/integration/framework/Magento/TestFramework/Event/Magento.php

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,27 @@ class Magento implements ObserverInterface
3030
*/
3131
protected static $_eventObject;
3232

33+
/**
34+
* @var $testPrepared
35+
*/
36+
protected static $testPrepared = false;
37+
38+
/**
39+
* set TestPrepared value
40+
*/
41+
public static function setTestPrepared($value)
42+
{
43+
self::$testPrepared = $value;
44+
}
45+
46+
/**
47+
* get TestPrepared value
48+
*/
49+
public static function getTestPrepared()
50+
{
51+
return self::$testPrepared;
52+
}
53+
3354
/**
3455
* Assign current Event Object
3556
*

dev/tests/integration/framework/Magento/TestFramework/Event/PhpUnit.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ public function startTestSuite(\PHPUnit\Framework\TestSuite $suite): void
102102
if ($suite instanceof \PHPUnit\Framework\DataProviderTestSuite) {
103103
return;
104104
}
105-
$this->_eventManager->fireEvent('testSuiteStarted');
105+
$this->_eventManager->fireEvent('startTestSuite');
106106
}
107107

108108
/**

dev/tests/integration/framework/Magento/TestFramework/Event/PhpUnitExtensionSubscriber.php

Lines changed: 0 additions & 30 deletions
This file was deleted.

dev/tests/integration/framework/Magento/TestFramework/Event/PhpUnitExtension.php renamed to dev/tests/integration/framework/Magento/TestFramework/Event/Subscribers.php

Lines changed: 19 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,38 +1,44 @@
11
<?php
22
/**
3-
* Copyright © Magento, Inc. All rights reserved.
4-
* See COPYING.txt for license details.
3+
* Copyright 2024 Adobe
4+
* All Rights Reserved.
55
*/
66

77
/**
8-
* Listener of PHPUnit built-in events
8+
* Subscribers of PHPUnit built-in events
99
*/
1010
namespace Magento\TestFramework\Event;
1111

1212
use PHPUnit\Runner;
1313
use PHPUnit\TextUI;
1414

15-
final class PhpUnitExtension implements Runner\Extension\Extension
15+
class Subscribers implements Runner\Extension\Extension
1616
{
17+
/**
18+
* Register Event Subscribers
19+
*
20+
* @param TextUI\Configuration\Configuration $configuration
21+
* @param Runner\Extension\Facade $facade
22+
* @param Runner\Extension\ParameterCollection $parameters
23+
*/
1724
public function bootstrap(
1825
TextUI\Configuration\Configuration $configuration,
1926
Runner\Extension\Facade $facade,
2027
Runner\Extension\ParameterCollection $parameters
21-
): void
22-
{
23-
if($configuration->hasConfigurationFile() &&
24-
str_contains($configuration->configurationFile(), 'setup-integration')){
28+
): void {
29+
if ($configuration->hasConfigurationFile() &&
30+
str_contains($configuration->configurationFile(), 'setup-integration')) {
2531
$facade->registerSubscribers(
26-
new PhpUnitExtensionSubscriber(),
27-
new PhpUnitExtensionSubscriberFinished()
32+
new TestPreprationStartedSubscriber(),
33+
new TestFinishedSubscriber()
2834
);
29-
}else{
35+
} else {
3036
$facade->registerSubscribers(
3137
new TestSuitStartedSubscriber(),
3238
new TestSuitEndSubscriber(),
3339
new TestPreparedSubscriber(),
34-
new PhpUnitExtensionSubscriber(),
35-
new PhpUnitExtensionSubscriberFinished(),
40+
new TestPreprationStartedSubscriber(),
41+
new TestFinishedSubscriber(),
3642
new TestSkippedSubscriber(),
3743
new TestErroredSubscriber()
3844
);

dev/tests/integration/framework/Magento/TestFramework/Event/TestErrored.php

Lines changed: 0 additions & 25 deletions
This file was deleted.
Lines changed: 17 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,31 +1,36 @@
11
<?php
22
/**
3-
* Copyright © Magento, Inc. All rights reserved.
4-
* See COPYING.txt for license details.
3+
* Copyright 2024 Adobe
4+
* All Rights Reserved.
55
*/
66

77
/**
8-
* Listener of PHPUnit built-in events
8+
* Test Errored Subscriber
99
*/
1010
namespace Magento\TestFramework\Event;
1111

1212
use PHPUnit\Event\Test\ErroredSubscriber;
1313
use PHPUnit\Event\Test\Errored;
1414
use Magento\TestFramework\Helper\Bootstrap;
1515

16-
final class TestErroredSubscriber implements ErroredSubscriber
16+
class TestErroredSubscriber implements ErroredSubscriber
1717
{
18-
public function notify(Errored $event): void{
18+
/**
19+
* Errored Subscriber
20+
*
21+
* @param Errored $event
22+
*/
23+
public function notify(Errored $event): void
24+
{
1925
$className = $event->test()->className();
2026
$methodName = $event->test()->methodName();
2127

22-
if(!in_array($methodName, ['testAclHasAccess', 'testAclNoAccess'])) {
23-
$objectManager = Bootstrap::getObjectManager();
24-
$assetRepo = $objectManager->create($className, ['name' => $methodName]);
28+
$objectManager = Bootstrap::getObjectManager();
29+
$assetRepo = $objectManager->create($className, ['name' => $methodName]);
2530

26-
$mageEvent = Magento::getDefaultEventManager();
27-
$mageEvent->fireEvent('endTest', [$assetRepo], true);
28-
Magento::setCurrentEventObject(null);
29-
}
31+
$mageEvent = Magento::getDefaultEventManager();
32+
$mageEvent->fireEvent('endTest', [$assetRepo], true);
33+
Magento::setCurrentEventObject(null);
34+
Magento::setTestPrepared(false);
3035
}
3136
}
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,25 @@
11
<?php
22
/**
3-
* Copyright © Magento, Inc. All rights reserved.
4-
* See COPYING.txt for license details.
3+
* Copyright 2024 Adobe
4+
* All Rights Reserved.
55
*/
66

77
/**
8-
* Listener of PHPUnit built-in events
8+
* Test Finished Subscriber
99
*/
1010
namespace Magento\TestFramework\Event;
1111

1212
use PHPUnit\Event\Test\FinishedSubscriber;
1313
use PHPUnit\Event\Test\Finished;
1414
use Magento\TestFramework\Helper\Bootstrap;
1515

16-
17-
final class PhpUnitExtensionSubscriberFinished implements FinishedSubscriber
16+
class TestFinishedSubscriber implements FinishedSubscriber
1817
{
18+
/**
19+
* Test finished Subscriber
20+
*
21+
* @param Finished $event
22+
*/
1923
public function notify(Finished $event): void
2024
{
2125
$className = $event->test()->className();
@@ -27,5 +31,6 @@ public function notify(Finished $event): void
2731
$mageEvent = Magento::getDefaultEventManager();
2832
$mageEvent->fireEvent('endTest', [$assetRepo], true);
2933
Magento::setCurrentEventObject(null);
34+
Magento::setTestPrepared(false);
3035
}
3136
}

0 commit comments

Comments
 (0)