ENGCOM-6016: Remove useless parentheses #24867

 - Merge Pull Request #24867 from DanielRuf/magento2:fix/remove-useless-parentheses
 - Merged commits:
   1. 8d1a45f
   2. 213031b

Author: magento-engcom-team

app/code/Magento/Catalog/Controller/Adminhtml/Product/Edit.php

@@ -4,10 +4,14 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+
 namespace Magento\Catalog\Controller\Adminhtml\Product;
 
 use Magento\Framework\App\Action\HttpGetActionInterface as HttpGetActionInterface;
 
+/**
+ *  Edit product
+ */
 class Edit extends \Magento\Catalog\Controller\Adminhtml\Product implements HttpGetActionInterface
 {
     /**
@@ -51,7 +55,7 @@ public function execute()
         $productId = (int) $this->getRequest()->getParam('id');
         $product = $this->productBuilder->build($this->getRequest());
 
-        if (($productId && !$product->getEntityId())) {
+        if ($productId && !$product->getEntityId()) {
             /** @var \Magento\Backend\Model\View\Result\Redirect $resultRedirect */
             $resultRedirect = $this->resultRedirectFactory->create();
             $this->messageManager->addErrorMessage(__('This product doesn\'t exist.'));

app/code/Magento/Catalog/Ui/DataProvider/Product/Form/Modifier/Eav.php

@@ -726,7 +726,7 @@ public function setupAttributeMeta(ProductAttributeInterface $attribute, $groupC
 
         // TODO: getAttributeModel() should not be used when MAGETWO-48284 is complete
         $childData = $this->arrayManager->get($configPath, $meta, []);
-        if (($rules = $this->catalogEavValidationRules->build($this->getAttributeModel($attribute), $childData))) {
+        if ($rules = $this->catalogEavValidationRules->build($this->getAttributeModel($attribute), $childData)) {
             $meta = $this->arrayManager->merge($configPath, $meta, ['validation' => $rules]);
         }
 

app/code/Magento/NewRelicReporting/Model/Apm/Deployments.php

@@ -7,6 +7,9 @@
 
 use \Magento\Framework\HTTP\ZendClient;
 
+/**
+ * Performs the request to make the deployment
+ */
 class Deployments
 {
     /**
@@ -88,7 +91,7 @@ public function setDeployment($description, $change = false, $user = false)
             return false;
         }
 
-        if (($response->getStatus() < 200 || $response->getStatus() > 210)) {
+        if ($response->getStatus() < 200 || $response->getStatus() > 210) {
             $this->logger->warning('Deployment marker request did not send a 200 status code.');
             return false;
         }

app/code/Magento/Persistent/Observer/MakePersistentQuoteGuestObserver.php

@@ -4,10 +4,16 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+
 namespace Magento\Persistent\Observer;
 
 use Magento\Framework\Event\ObserverInterface;
 
+/**
+ *  Make persistent quote to be guest
+ *
+ * @SuppressWarnings(PHPMD.CookieAndSessionMisuse)
+ */
 class MakePersistentQuoteGuestObserver implements ObserverInterface
 {
     /**
@@ -65,8 +71,8 @@ public function execute(\Magento\Framework\Event\Observer $observer)
         /** @var $action \Magento\Persistent\Controller\Index */
         $action = $observer->getEvent()->getControllerAction();
         if ($action instanceof \Magento\Persistent\Controller\Index) {
-            if ((($this->_persistentSession->isPersistent() && !$this->_customerSession->isLoggedIn())
-                || $this->_persistentData->isShoppingCartPersist())
+            if (($this->_persistentSession->isPersistent() && !$this->_customerSession->isLoggedIn())
+                || $this->_persistentData->isShoppingCartPersist()
             ) {
                 $this->quoteManager->setGuest(true);
             }

app/code/Magento/Ui/Component/Control/SplitButton.php

@@ -3,6 +3,7 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+
 namespace Magento\Ui\Component\Control;
 
 /**
@@ -22,7 +23,7 @@
 class SplitButton extends Button
 {
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     protected function getTemplatePath()
     {
@@ -83,12 +84,12 @@ public function getButtonAttributesHtml()
             'style' => $this->getStyle(),
         ];
 
-        if (($idHard = $this->getIdHard())) {
+        if ($idHard = $this->getIdHard()) {
             $attributes['id'] = $idHard;
         }
 
         //TODO perhaps we need to skip data-mage-init when disabled="disabled"
-        if (($dataAttribute = $this->getDataAttribute())) {
+        if ($dataAttribute = $this->getDataAttribute()) {
             $this->getDataAttributes($dataAttribute, $attributes);
         }
 
@@ -112,7 +113,7 @@ public function getToggleAttributesHtml()
             $title = $this->getLabel();
         }
 
-        if (($currentClass = $this->getClass())) {
+        if ($currentClass = $this->getClass()) {
             $classes[] = $currentClass;
         }
 
@@ -201,12 +202,11 @@ public function hasSplit()
     {
         return $this->hasData('has_split') ? (bool)$this->getData('has_split') : true;
     }
-
     /**
      * Add data attributes to $attributes array
      *
      * @param array $data
-     * @param array &$attributes
+     * @param array $attributes
      * @return void
      */
     protected function getDataAttributes($data, &$attributes)

dev/tests/functional/tests/app/Magento/Catalog/Test/Fixture/Product/TaxClass.php

@@ -52,7 +52,7 @@ class TaxClass extends DataSource
     public function __construct(FixtureFactory $fixtureFactory, array $params, $data = [])
     {
         $this->params = $params;
-        if ((!isset($data['dataset']) && !isset($data['tax_product_class']))) {
+        if (!isset($data['dataset']) && !isset($data['tax_product_class'])) {
             $this->data = $data;
             return;
         }

setup/src/Magento/Setup/Model/Installer.php

@@ -429,7 +429,7 @@ private function createModulesConfig($request, $dryRun = false)
         $disable = $this->readListOfModules($all, $request, InstallCommand::INPUT_KEY_DISABLE_MODULES);
         $result = [];
         foreach ($all as $module) {
-            if ((isset($currentModules[$module]) && !$currentModules[$module])) {
+            if (isset($currentModules[$module]) && !$currentModules[$module]) {
                 $result[$module] = 0;
             } else {
                 $result[$module] = 1;
@@ -925,7 +925,7 @@ private function throwExceptionForNotWritablePaths(array $paths)
      */
     private function handleDBSchemaData($setup, $type, array $request)
     {
-        if (!(($type === 'schema') || ($type === 'data'))) {
+        if (!($type === 'schema' || $type === 'data')) {
             throw  new \Magento\Setup\Exception("Unsupported operation type $type is requested");
         }
         $resource = new \Magento\Framework\Module\ModuleResource($this->context);