AC-10634: Static Test Fixes

Author: nishant04412

app/code/Magento/Authorization/Test/Unit/Model/ResourceModel/RulesTest.php

@@ -35,7 +35,7 @@ class RulesTest extends TestCase
     /**
      * Test constants
      */
-    const TEST_ROLE_ID = 13;
+    private const TEST_ROLE_ID = 13;
 
     /**
      * @var Rules

app/code/Magento/Backend/Test/Unit/Controller/Adminhtml/Auth/LoginTest.php

@@ -30,6 +30,8 @@
 
 /**
  * Test for \Magento\Backend\Controller\Adminhtml\Auth\Login.
+ *
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class LoginTest extends TestCase
 {

app/code/Magento/Bundle/Test/Unit/Controller/Adminhtml/Product/Initialization/Helper/Plugin/BundleTest.php

@@ -1,11 +1,9 @@
 <?php
-declare(strict_types=1);
 /**
- * Test class for \Magento\Bundle\Controller\Adminhtml\Product\Initialization\Helper\Plugin\Bundle
- *
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
 
 namespace Magento\Bundle\Test\Unit\Controller\Adminhtml\Product\Initialization\Helper\Plugin;
 

app/code/Magento/Bundle/Test/Unit/Model/Plugin/PriceBackendTest.php

@@ -18,7 +18,7 @@
 
 class PriceBackendTest extends TestCase
 {
-    const CLOSURE_VALUE = 'CLOSURE';
+    private const CLOSURE_VALUE = 'CLOSURE';
 
     /** @var  PriceBackend */
     private $priceBackendPlugin;

app/code/Magento/Captcha/Test/Unit/Model/DefaultTest.php

@@ -32,7 +32,7 @@ class DefaultTest extends TestCase
     /**
      * Expiration frame
      */
-    const EXPIRE_FRAME = 86400;
+    private const EXPIRE_FRAME = 86400;
 
     /**
      * Captcha default config data

app/code/Magento/Captcha/Test/Unit/Observer/CheckUserForgotPasswordBackendObserverTest.php

@@ -29,8 +29,8 @@
  */
 class CheckUserForgotPasswordBackendObserverTest extends TestCase
 {
-    const STUB_EMAIL = '[email protected]';
-    const STUB_REQUEST_PARAMS = ['STUB_PARAM'];
+    private const STUB_EMAIL = '[email protected]';
+    private const STUB_REQUEST_PARAMS = ['STUB_PARAM'];
 
     /**
      * @var MockObject|DataHelper

app/code/Magento/Catalog/Test/Unit/Model/Attribute/Backend/TierPrice/UpdateHandlerTest.php

@@ -30,7 +30,7 @@
 class UpdateHandlerTest extends TestCase
 {
     /**
-     * Magento\Framework\TestFramework\Unit\Helper\ObjectManager
+     * @var Magento\Framework\TestFramework\Unit\Helper\ObjectManager
      */
     private $objectManager;
 

app/code/Magento/Directory/Test/Unit/Model/Config/Source/AllRegionTest.php

@@ -35,8 +35,7 @@ protected function setUp(): void
     {
         $objectManagerHelper = new ObjectManager($this);
 
-        $countryCollectionFactory = $this->getMockBuilder(
-            CollectionFactory::class)
+        $countryCollectionFactory = $this->getMockBuilder(CollectionFactory::class)
             ->addMethods(['__wakeup', '__sleep'])
             ->onlyMethods(['create'])
             ->disableOriginalConstructor()

lib/internal/Magento/Framework/TestFramework/Unit/Helper/ObjectManager.php

@@ -364,7 +364,9 @@ public function setBackwardCompatibleProperty($object, $propertyName, $propertyV
     }
 
     /**
-     * @param $map
+     * Helper method to get mock of ObjectManagerInterface
+     *
+     * @param array $map
      */
     public function prepareObjectManager($map)
     {