MC-38593: Complex products children ids are not cached in Type class leading to multiple unnecessary db requests

engcom-Echo · engcom-Echo · commit bd51f4d00a52 · 2020-11-06T10:52:05.000+02:00
diff --git a/app/code/Magento/Bundle/Model/Product/Type.php b/app/code/Magento/Bundle/Model/Product/Type.php
@@ -315,7 +315,7 @@ public function getParentIdsByChild($childId)
             return $this->_bundleSelection->getParentIdsByChild($childId);
         }
 
-        $cacheKey = is_array($childId) ? implode('-', $childId) : $childId;
+        $cacheKey = is_array($childId) ? array_shift($childId) : $childId;
         if (!isset($this->cacheParentIdsByChild[$cacheKey])) {
             $this->cacheParentIdsByChild[$cacheKey] = $this->_bundleSelection->getParentIdsByChild($childId);
         }

Original file line number	Diff line number	Diff line change
`@@ -315,7 +315,7 @@ public function getParentIdsByChild($childId)`
`315`	`315`	`return $this->_bundleSelection->getParentIdsByChild($childId);`
`316`	`316`	`}`
`317`	`317`
`318`		`- $cacheKey = is_array($childId) ? implode('-', $childId) : $childId;`
	`318`	`+ $cacheKey = is_array($childId) ? array_shift($childId) : $childId;`
`319`	`319`	`if (!isset($this->cacheParentIdsByChild[$cacheKey])) {`
`320`	`320`	`$this->cacheParentIdsByChild[$cacheKey] = $this->_bundleSelection->getParentIdsByChild($childId);`
`321`	`321`	`}`