MAGETWO-36337: Not user-friendly behaviour of "Save in address book" check-box inside "Shipping Address" section on "create Order" Admin page

eugene-petrov · eugene-petrov · commit c1dd183a0f11 · 2019-05-16T08:45:45.000+03:00
diff --git a/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Shipping/Address.php b/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Shipping/Address.php
@@ -3,6 +3,8 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
+
 namespace Magento\Sales\Block\Adminhtml\Order\Create\Shipping;
 
 /**
@@ -88,7 +90,7 @@ public function getDontSaveInAddressBook()
             return !$save;
         }
         if ($shippingIsTheSameAsBilling) {
-            return !($this->getIsAsBilling() && $this->getIsShipping());
+            return !$shippingIsTheSameAsBilling;
         }
         return $this->getIsAsBilling();
     }

Original file line number	Diff line number	Diff line change
`@@ -3,6 +3,8 @@`
`3`	`3`	`* Copyright © Magento, Inc. All rights reserved.`
`4`	`4`	`* See COPYING.txt for license details.`
`5`	`5`	`*/`
	`6`	`+declare(strict_types=1);`
	`7`	`+`
`6`	`8`	`namespace Magento\Sales\Block\Adminhtml\Order\Create\Shipping;`
`7`	`9`
`8`	`10`	`/**`
`@@ -88,7 +90,7 @@ public function getDontSaveInAddressBook()`
`88`	`90`	`return !$save;`
`89`	`91`	`}`
`90`	`92`	`if ($shippingIsTheSameAsBilling) {`
`91`		`- return !($this->getIsAsBilling() && $this->getIsShipping());`
	`93`	`+ return !$shippingIsTheSameAsBilling;`
`92`	`94`	`}`
`93`	`95`	`return $this->getIsAsBilling();`
`94`	`96`	`}`