ENGCOM-5825: Refactor isSubscribed method to return the output of the expression #24534

magento-engcom-team · magento-engcom-team · commit c472b8c8c4aa · 2019-09-10T10:54:22.000-05:00
- Merge Pull Request #24534 from will-in-wi/magento2:simplify-boolean-return - Merged commits: 1. 5830d5d 2. 0f140b0 3. f0b9a96
diff --git a/app/code/Magento/Newsletter/Model/Subscriber.php b/app/code/Magento/Newsletter/Model/Subscriber.php
@@ -353,11 +353,7 @@ public function isStatusChanged()
      */
     public function isSubscribed()
     {
-        if ($this->getId() && $this->getStatus() == self::STATUS_SUBSCRIBED) {
-            return true;
-        }
-
-        return false;
+        return $this->getId() && (int)$this->getStatus() === self::STATUS_SUBSCRIBED;
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -353,11 +353,7 @@ public function isStatusChanged()`
`353`	`353`	`*/`
`354`	`354`	`public function isSubscribed()`
`355`	`355`	`{`
`356`		`- if ($this->getId() && $this->getStatus() == self::STATUS_SUBSCRIBED) {`
`357`		`- return true;`
`358`		`- }`
`359`		`-`
`360`		`- return false;`
	`356`	`+ return $this->getId() && (int)$this->getStatus() === self::STATUS_SUBSCRIBED;`
`361`	`357`	`}`
`362`	`358`
`363`	`359`	`/**`