MC-38593: Complex products children ids are not cached in Type class leading to multiple unnecessary db requests

Author: engcom-Echo

app/code/Magento/Bundle/Model/Plugin/Frontend/ProductIdentitiesExtender.php

@@ -60,7 +60,7 @@ public function afterGetIdentities(CatalogProduct $product, array $identities):
      * @param mixed $entityId
      * @return array
      */
-    private function getChildrenIds($entityId)
+    private function getChildrenIds($entityId): array
     {
         if (!isset($this->cacheChildrenIds[$entityId])) {
             $this->cacheChildrenIds[$entityId] = $this->type->getChildrenIds($entityId);

app/code/Magento/Bundle/Model/Plugin/ProductIdentitiesExtender.php

@@ -10,6 +10,9 @@
 use Magento\Bundle\Model\Product\Type as BundleType;
 use Magento\Catalog\Model\Product as CatalogProduct;
 
+/**
+ * Add parent identities to product identities.
+ */
 class ProductIdentitiesExtender
 {
     /**
@@ -47,6 +50,7 @@ public function afterGetIdentities(
         foreach ($this->getParentIdsByChild($product->getEntityId()) as $parentId) {
             $identities[] = CatalogProduct::CACHE_TAG . '_' . $parentId;
         }
+
         return $identities;
     }
 
@@ -56,7 +60,7 @@ public function afterGetIdentities(
      * @param mixed $entityId
      * @return array
      */
-    private function getParentIdsByChild($entityId)
+    private function getParentIdsByChild($entityId): array
     {
         if (!isset($this->cacheParentIdsByChild[$entityId])) {
             $this->cacheParentIdsByChild[$entityId] = $this->type->getParentIdsByChild($entityId);

app/code/Magento/Bundle/Test/Unit/Model/Plugin/Frontend/ProductIdentitiesExtenderTest.php

@@ -13,17 +13,23 @@
 use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
 
+/**
+ * Unit test for \Magento\Bundle\Model\Plugin\Frontend\ProductIdentitiesExtender
+ */
 class ProductIdentitiesExtenderTest extends TestCase
 {
-    /** @var  \Magento\Bundle\Model\Plugin\Product */
+    /** @var ProductPlugin */
     private $plugin;
 
-    /** @var  MockObject|Type */
+    /** @var MockObject|Type */
     private $type;
 
-    /** @var  MockObject|\Magento\Catalog\Model\Product */
+    /** @var MockObject|Product */
     private $product;
 
+    /**
+     * @inheritdoc
+     */
     protected function setUp(): void
     {
         $this->product = $this->getMockBuilder(Product::class)
@@ -39,7 +45,7 @@ protected function setUp(): void
         $this->plugin = new ProductPlugin($this->type);
     }
 
-    public function testAfterGetIdentities()
+    public function testAfterGetIdentities(): void
     {
         $baseIdentities = [
             'SomeCacheId',

app/code/Magento/Bundle/Test/Unit/Model/Plugin/ProductIdentitiesExtenderTest.php

@@ -14,6 +14,9 @@
 use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
 
+/**
+ * Unit test for \Magento\Bundle\Model\Plugin\ProductIdentitiesExtender
+ */
 class ProductIdentitiesExtenderTest extends TestCase
 {
     /** @var Plugin */