Skip to content

Commit c7aa331

Browse files
Devagouda PatilDevagouda Patil
authored andcommitted
MAGETWO-93978: Footer Overlaps Storefront Page Content In Mobile View
- Incorporated review comments of functional test
1 parent 3b4deb3 commit c7aa331

File tree

1 file changed

+9
-6
lines changed

1 file changed

+9
-6
lines changed

app/code/Magento/Cms/Test/Mftf/Test/StoreFrontMobileViewValidation.xml

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,29 +15,32 @@
1515
<description value="Mobile view page footer should stick to the bottom of page on Store front"/>
1616
<severity value="MAJOR"/>
1717
<testCaseId value="MAGETWO-94333"/>
18+
<useCaseId value="MAGETWO-93978"/>
1819
<group value="Cms"/>
1920
</annotations>
2021
<before>
2122
<createData entity="_longContentCmsPage" stepKey="createPreReqCMSPage"/>
2223
</before>
2324
<after>
2425
<deleteData createDataKey="createPreReqCMSPage" stepKey="deletePreReqCMSPage"/>
26+
<resizeWindow width="1280" height="1024" stepKey="resizeWindowToDesktop"/>
2527
</after>
26-
<resizeWindow width="375" height="812" stepKey="resizeWindowToDesktop"/>
28+
<resizeWindow width="375" height="812" stepKey="resizeWindowToMobile"/>
2729
<amOnPage url="$$createPreReqCMSPage.identifier$$" stepKey="amOnPageTestPage"/>
2830
<waitForPageLoad stepKey="waitForPageLoad6" />
29-
<!--check header/footer location on Storefront-->
31+
<!-- Verifying that Footer is not in visible area by default as the CMS page has lots of content which -->
3032
<executeJS function="return document.querySelector('{{StorefrontCMSPageFooterSection.footerSection}}').getBoundingClientRect().top" stepKey="topOfFooter"/>
3133
<assertGreaterThan stepKey="assertDefaultLoad">
3234
<actualResult type="variable">topOfFooter</actualResult>
3335
<expectedResult type="string">812</expectedResult>
3436
</assertGreaterThan>
37+
<!-- Verifying that even after scroll footer section is below the main content section -->
3538
<scrollTo selector="{{StorefrontCMSPageFooterSection.footerSection}}" stepKey="scrollToFooterSection"/>
36-
<executeJS function="return document.querySelector('{{StorefrontCMSPageFooterSection.footerSection}}').getBoundingClientRect().top" stepKey="bottomOfFooter"/>
37-
<executeJS function="return document.querySelector('{{StorefrontCMSPageSection.mainContent}}').getBoundingClientRect().bottom" stepKey="mainContent"/>
39+
<executeJS function="return document.querySelector('{{StorefrontCMSPageFooterSection.footerSection}}').getBoundingClientRect().top" stepKey="topOfTheFooterAfterScroll"/>
40+
<executeJS function="return document.querySelector('{{StorefrontCMSPageSection.mainContent}}').getBoundingClientRect().bottom" stepKey="bottomOfMainContent"/>
3841
<assertGreaterThan stepKey="assertAfterScroll">
39-
<actualResult type="variable">bottomOfFooter</actualResult>
40-
<expectedResult type="variable">mainContent</expectedResult>
42+
<actualResult type="variable">topOfTheFooterAfterScroll</actualResult>
43+
<expectedResult type="variable">bottomOfMainContent</expectedResult>
4144
</assertGreaterThan>
4245
</test>
4346
</tests>

0 commit comments

Comments
 (0)