AC-10815 - API Input validation

sreenia806 · sreenia806 · commit c7d58d0989d3 · 2024-04-22T22:19:18.000+05:30
diff --git a/lib/internal/Magento/Framework/Webapi/ServiceInputProcessor.php b/lib/internal/Magento/Framework/Webapi/ServiceInputProcessor.php
@@ -228,10 +228,11 @@ public function process($serviceClassName, $serviceMethodName, array $inputArray
     private function getConstructorData(string $className, array $data): array
     {
         $preferenceClass = $this->config->getPreference($className);
-        $class = new ClassReflection($preferenceClass ?: $className);
-        if ($class->isSubclassOf(\SimpleXMLElement::class) || $class->isSubclassOf( \DOMNode::class)) {
+        if (is_subclass_of($preferenceClass, \SimpleXMLElement::class)
+            || is_subclass_of($preferenceClass, \DOMElement::class)) {
             return [];
         }
+        $class = new ClassReflection($preferenceClass ?: $className);
 
         try {
             $constructor = $class->getMethod('__construct');

Original file line number	Diff line number	Diff line change
`@@ -228,10 +228,11 @@ public function process($serviceClassName, $serviceMethodName, array $inputArray`
`228`	`228`	`private function getConstructorData(string $className, array $data): array`
`229`	`229`	`{`
`230`	`230`	`$preferenceClass = $this->config->getPreference($className);`
`231`		`- $class = new ClassReflection($preferenceClass ?: $className);`
`232`		`- if ($class->isSubclassOf(\SimpleXMLElement::class) \|\| $class->isSubclassOf( \DOMNode::class)) {`
	`231`	`+ if (is_subclass_of($preferenceClass, \SimpleXMLElement::class)`
	`232`	`+ \|\| is_subclass_of($preferenceClass, \DOMElement::class)) {`
`233`	`233`	`return [];`
`234`	`234`	`}`
	`235`	`+ $class = new ClassReflection($preferenceClass ?: $className);`
`235`	`236`
`236`	`237`	`try {`
`237`	`238`	`$constructor = $class->getMethod('__construct');`