MC-38593: Complex products children ids are not cached in Type class leading to multiple unnecessary db requests

Author: engcom-Echo

app/code/Magento/Bundle/Test/Unit/Model/Plugin/ProductTest.php

@@ -8,14 +8,15 @@
 namespace Magento\Bundle\Test\Unit\Model\Plugin;
 
 use Magento\Bundle\Model\Product\Type;
+use Magento\Bundle\Model\Plugin\Product as Plugin;
 use Magento\Catalog\Model\Product;
 use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
 use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
 
 class ProductTest extends TestCase
 {
-    /** @var  \Magento\Bundle\Model\Plugin\Product */
+    /** @var Plugin */
     private $plugin;
 
     /** @var  MockObject|Type */
@@ -30,15 +31,15 @@ protected function setUp(): void
 
         $this->product = $this->getMockBuilder(Product::class)
             ->disableOriginalConstructor()
-            ->setMethods(['getEntityId'])
+            ->setMethods(['getEntityId', 'getTypeId'])
             ->getMock();
         $this->type = $this->getMockBuilder(Type::class)
             ->disableOriginalConstructor()
             ->setMethods(['getParentIdsByChild'])
             ->getMock();
 
         $this->plugin = $objectManager->getObject(
-            \Magento\Bundle\Model\Plugin\Product::class,
+            Plugin::class,
             [
                 'type' => $this->type,
             ]
@@ -64,6 +65,9 @@ public function testAfterGetIdentities()
         $this->product->expects($this->once())
             ->method('getEntityId')
             ->willReturn($id);
+        $this->product->expects($this->once())
+            ->method('getTypeId')
+            ->willReturn(Type::TYPE_CODE);
         $this->type->expects($this->once())
             ->method('getParentIdsByChild')
             ->with($id)

app/code/Magento/ConfigurableProduct/Model/Plugin/ProductIdentitiesExtender.php

@@ -49,12 +49,12 @@ public function afterGetIdentities(Product $subject, array $identities): array
         if ($subject->getTypeId() !== ConfigurableType::TYPE_CODE) {
             return $identities;
         }
-        $parentProductIdentities = [];
+        $parentProductsIdentities = [];
         foreach ($this->configurableType->getParentIdsByChild($subject->getId()) as $parentId) {
             $parentProduct = $this->productRepository->getById($parentId);
-            $parentProductIdentities[] = $parentProduct->getIdentities();
+            $parentProductsIdentities[] = $parentProduct->getIdentities();
         }
-        $identities = array_merge($identities, $parentProductIdentities);
+        $identities = array_merge($identities, ...$parentProductsIdentities);
 
         return array_unique($identities);
     }

app/code/Magento/ConfigurableProduct/Test/Unit/Model/Plugin/ProductIdentitiesExtenderTest.php

@@ -58,6 +58,9 @@ public function testAfterGetIdentities()
         $productMock->expects($this->once())
             ->method('getId')
             ->willReturn($productId);
+        $productMock->expects($this->once())
+            ->method('getTypeId')
+            ->willReturn(Configurable::TYPE_CODE);
         $this->configurableTypeMock->expects($this->once())
             ->method('getParentIdsByChild')
             ->with($productId)