Return 0 instead of null when stock is zero

Cody Nguyen · Cody Nguyen · commit c96f7a4eea76 · 2020-09-12T07:39:51.000+07:00
diff --git a/app/code/Magento/CatalogInventoryGraphQl/Model/Resolver/OnlyXLeftInStockResolver.php b/app/code/Magento/CatalogInventoryGraphQl/Model/Resolver/OnlyXLeftInStockResolver.php
@@ -86,7 +86,7 @@ private function getOnlyXLeftQty(ProductInterface $product): ?float
 
         $stockLeft = $stockCurrentQty - $stockItem->getMinQty();
 
-        if ($stockLeft > 0 && $stockLeft <= $thresholdQty) {
+        if ($stockCurrentQty >= 0 && $stockLeft <= $thresholdQty) {
             return (float)$stockCurrentQty;
         }
 
diff --git a/app/code/Magento/CatalogInventoryGraphQl/Test/Unit/Model/Resolver/OnlyXLeftInStockResolverTest.php b/app/code/Magento/CatalogInventoryGraphQl/Test/Unit/Model/Resolver/OnlyXLeftInStockResolverTest.php
@@ -169,7 +169,7 @@ public function testResolveOutStock()
         $this->scopeConfigMock->method('getValue')->willReturn($thresholdQty);
 
         $this->assertEquals(
-            null,
+            0,
             $this->resolver->resolve(
                 $this->fieldMock,
                 $this->contextMock,

Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,7 @@ private function getOnlyXLeftQty(ProductInterface $product): ?float`
`86`	`86`
`87`	`87`	`$stockLeft = $stockCurrentQty - $stockItem->getMinQty();`
`88`	`88`
`89`		`- if ($stockLeft > 0 && $stockLeft <= $thresholdQty) {`
	`89`	`+ if ($stockCurrentQty >= 0 && $stockLeft <= $thresholdQty) {`
`90`	`90`	`return (float)$stockCurrentQty;`
`91`	`91`	`}`
`92`	`92`