MAGETWO-63737: [FT] Analytics Subscription Tests are failing on CI

Author: olysenko

dev/tests/functional/tests/app/Magento/Analytics/Test/Constraint/AssertAcceptSubscriptionPopup.php

@@ -9,12 +9,12 @@
 use Magento\Mtf\Constraint\AbstractConstraint;
 
 /**
- * Verify that admin user accepted analytics pop-up
+ * Verify that admin user chose to accept subscription in Analytics pop-up.
  */
 class AssertAcceptSubscriptionPopup extends AbstractConstraint
 {
     /**
-     * Verify that admin user accepted analytics pop-up
+     * Verify that admin user chose to accept subscription in Analytics pop-up.
      *
      * @param Dashboard $dashboard
      * @return void
@@ -31,7 +31,7 @@ public function processAssert(Dashboard $dashboard)
     }
 
     /**
-     * Returns success message if equals to expected message.
+     * Returns a string representation of the object.
      *
      * @return string
      */

dev/tests/functional/tests/app/Magento/Analytics/Test/Constraint/AssertConfigAnalyticsDisabled.php

@@ -54,7 +54,7 @@ public function processAssert(
      */
     public function toString()
     {
-        return 'Magento Analytics is disabled in Stores > Configuration > General > Analytics > General menu
-        and has disabled status';
+        return 'Magento Analytics is disabled in Stores > Configuration > General > Analytics > General menu'
+            . ' and has Disabled status';
     }
 }

dev/tests/functional/tests/app/Magento/Analytics/Test/Constraint/AssertConfigAnalyticsEnabled.php

@@ -54,7 +54,7 @@ public function processAssert(
      */
     public function toString()
     {
-        return 'Magento Analytics is enabled and has Pending status in
-         Stores > Configuration > General > Analytics > General menu.';
+        return 'Magento Analytics is enabled and has Pending status in'
+            . ' Stores > Configuration > General > Analytics > General menu.';
     }
 }

dev/tests/functional/tests/app/Magento/Analytics/Test/Constraint/AssertConfigAnalyticsRestored.php

@@ -16,7 +16,7 @@
 class AssertConfigAnalyticsRestored extends AbstractConstraint
 {
     /**
-     * Assert Analytics sending data to the Analytics is restored.
+     * Assert sending data to the Analytics is restored.
      *
      * @param ConfigAnalytics $configAnalytics
      * @param Dashboard $dashboard
@@ -44,7 +44,7 @@ public function processAssert(
 
         \PHPUnit_Framework_Assert::assertTrue(
             $systemConfigPage->getMessagesBlock()->assertSuccessMessage(),
-            'Magento Analytics settings are not saved'
+            'Sending data to the Analytics is not saved'
         );
     }
 
@@ -55,6 +55,6 @@ public function processAssert(
      */
     public function toString()
     {
-        return 'Magento Analytics setting are saved';
+        return 'Sending data to the Analytics is saved';
     }
 }

dev/tests/functional/tests/app/Magento/Analytics/Test/Constraint/AssertConfigAnalyticsStatusDisabled.php

@@ -9,12 +9,12 @@
 use Magento\Mtf\Constraint\AbstractConstraint;
 
 /**
- * Verify that admin user declined analytics pop-up
+ * Verify that admin user chose to decline subscription in Analytics pop-up.
  */
 class AssertDeclineSubscriptionPopup extends AbstractConstraint
 {
     /**
-     * Verify that admin user declined analytics pop-up
+     * Verify that admin user chose to decline subscription in Analytics pop-up.
      *
      * @param Dashboard $dashboard
      * @return void
@@ -31,7 +31,7 @@ public function processAssert(Dashboard $dashboard)
     }
 
     /**
-     * Returns success message if equals to expected message.
+     * Returns a string representation of the object.
      *
      * @return string
      */

dev/tests/functional/tests/app/Magento/Analytics/Test/Constraint/AssertConfigAnalyticsStatusPending.php

@@ -31,7 +31,7 @@ public function processAssert(Dashboard $dashboard)
     }
 
     /**
-     * Returns success message if equals to expected message.
+     * Returns a string representation of the object.
      *
      * @return string
      */