MAGETWO-64523: Add static test on forbidden "final" keyword and eliminate it usage in code

 - final keyword usage removal

Author: Volodymyr Kublytskyi

app/code/Magento/Braintree/Model/Ui/ConfigProvider.php

@@ -13,7 +13,7 @@
 /**
  * Class ConfigProvider
  */
-final class ConfigProvider implements ConfigProviderInterface
+class ConfigProvider implements ConfigProviderInterface
 {
     const CODE = 'braintree';
 

app/code/Magento/Vault/Model/Method/Vault.php

@@ -28,7 +28,7 @@
  * @SuppressWarnings(PHPMD.ExcessivePublicCount)
  * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
-final class Vault implements VaultPaymentInterface
+class Vault implements VaultPaymentInterface
 {
     /**
      * @deprecated

app/code/Magento/Vault/Model/Ui/Adminhtml/TokensConfigProvider.php

@@ -27,7 +27,7 @@
  * @api
  * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
-final class TokensConfigProvider
+class TokensConfigProvider
 {
     /**
      * @var PaymentTokenRepositoryInterface

app/code/Magento/Vault/Model/Ui/TokensConfigProvider.php

@@ -15,7 +15,7 @@
  * Class ConfigProvider
  * @api
  */
-final class TokensConfigProvider implements ConfigProviderInterface
+class TokensConfigProvider implements ConfigProviderInterface
 {
     /**
      * @var string

dev/tests/integration/testsuite/Magento/Framework/Code/GeneratorTest/ParentClassWithNamespace.php

@@ -78,6 +78,9 @@ public static function publicParentStatic()
     {
     }
 
+    /**
+     * @SuppressWarnings(PHPMD.FinalImplementation) Suppressed as is a fixture but not a real code
+     */
     final public function publicParentFinal()
     {
     }

dev/tests/integration/testsuite/Magento/Framework/Code/GeneratorTest/SourceClassWithNamespace.php

@@ -104,6 +104,9 @@ public static function publicChildStatic()
     {
     }
 
+    /**
+     * @SuppressWarnings(PHPMD.FinalImplementation) Suppressed as is a fixture but not a real code
+     */
     final public function publicChildFinal()
     {
     }

dev/tests/integration/testsuite/Magento/Framework/Interception/Fixture/Intercepted.php

@@ -48,6 +48,7 @@ public function D($param1)
 
     /**
      * @SuppressWarnings(PHPMD.ShortMethodName)
+     * @SuppressWarnings(PHPMD.FinalImplementation) Suppressed as is a fixture but not a real code
      */
     final public function E($param1)
     {

lib/internal/Magento/Framework/Archive/Tar.php

@@ -84,7 +84,7 @@ protected function _initWriter()
      *
      * @return string
      */
-    final protected static function _getFormatParseHeader()
+    protected static function _getFormatParseHeader()
     {
         return 'a100name/a8mode/a8uid/a8gid/a12size/a12mtime/a8checksum/a1type/a100symlink/a6magic/a2version/' .
             'a32uname/a32gname/a8devmajor/a8devminor/a155prefix/a12closer';

lib/internal/Magento/Framework/Code/Test/Unit/Generator/TestAsset/ParentClass.php

@@ -78,6 +78,9 @@ public static function publicParentStatic()
     {
     }
 
+    /**
+     * @SuppressWarnings(PHPMD.FinalImplementation) Suppressed as is a fixture but not a real code
+     */
     final public function publicParentFinal()
     {
     }

lib/internal/Magento/Framework/Code/Test/Unit/Generator/TestAsset/SourceClass.php

@@ -112,6 +112,9 @@ public static function publicChildStatic()
     {
     }
 
+    /**
+     * @SuppressWarnings(PHPMD.FinalImplementation) Suppressed as is a fixture but not a real code
+     */
     final public function publicChildFinal()
     {
     }