Skip to content

Commit cd75c92

Browse files
authored
ENGCOM-4356: Removed unused else block and corrected return types #21405
2 parents 2ec994e + a0bba02 commit cd75c92

File tree

4 files changed

+14
-4
lines changed

4 files changed

+14
-4
lines changed

app/code/Magento/Fedex/Model/Carrier.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -363,7 +363,6 @@ public function setRequest(RateRequest $request)
363363

364364
if ($request->getDestPostcode()) {
365365
$r->setDestPostal($request->getDestPostcode());
366-
} else {
367366
}
368367

369368
if ($request->getDestCity()) {

app/code/Magento/GiftMessage/Block/Adminhtml/Sales/Order/View/Items.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ public function getMessage()
171171
/**
172172
* Retrieve save url
173173
*
174-
* @return array
174+
* @return string
175175
* @codeCoverageIgnore
176176
*/
177177
public function getSaveUrl()

app/code/Magento/GiftMessage/Block/Cart/GiftOptions.php

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,16 @@
33
* Copyright © Magento, Inc. All rights reserved.
44
* See COPYING.txt for license details.
55
*/
6+
67
namespace Magento\GiftMessage\Block\Cart;
78

89
use Magento\Backend\Block\Template\Context;
910
use Magento\Framework\Json\Encoder;
1011
use Magento\GiftMessage\Model\CompositeConfigProvider;
1112

1213
/**
14+
* Gift options cart block.
15+
*
1316
* @api
1417
* @since 100.0.2
1518
*/
@@ -63,6 +66,8 @@ public function __construct(
6366
}
6467

6568
/**
69+
* Retrieve encoded js layout.
70+
*
6671
* @return string
6772
*/
6873
public function getJsLayout()
@@ -76,7 +81,7 @@ public function getJsLayout()
7681
/**
7782
* Retrieve gift message configuration
7883
*
79-
* @return array
84+
* @return string
8085
*/
8186
public function getGiftOptionsConfigJson()
8287
{

app/code/Magento/GiftMessage/Model/Type/Plugin/Onepage.php

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,12 @@
33
* Copyright © Magento, Inc. All rights reserved.
44
* See COPYING.txt for license details.
55
*/
6+
67
namespace Magento\GiftMessage\Model\Type\Plugin;
78

9+
/**
10+
* Add gift message to quote plugin.
11+
*/
812
class Onepage
913
{
1014
/**
@@ -30,9 +34,11 @@ public function __construct(
3034
}
3135

3236
/**
37+
* Add gift message ot quote.
38+
*
3339
* @param \Magento\Checkout\Model\Type\Onepage $subject
3440
* @param array $result
35-
* @return $this
41+
* @return array
3642
*/
3743
public function afterSaveShippingMethod(
3844
\Magento\Checkout\Model\Type\Onepage $subject,

0 commit comments

Comments
 (0)