Skip to content

Commit cdd13d6

Browse files
#39729: Cannot return null for non-nullable field
- Refactor callback signatures in unit tests.
1 parent 701d6bf commit cdd13d6

File tree

1 file changed

+17
-4
lines changed

1 file changed

+17
-4
lines changed

app/code/Magento/QuoteGraphQl/Test/Unit/Model/Resolver/CustomizableOptionsTest.php

Lines changed: 17 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919

2020
/**
2121
* Unit test for CustomizableOptions resolver
22+
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
2223
*/
2324
class CustomizableOptionsTest extends TestCase
2425
{
@@ -153,7 +154,10 @@ public function testResolveReturnsCustomizableOptionsData(): void
153154
$this->customizableOptionMock->expects($this->exactly(3))
154155
->method('getData')
155156
->willReturnCallback(
156-
function ($unused, $optionId) use (
157+
function (
158+
QuoteItem $item,
159+
int $optionId
160+
) use (
157161
$expectedOptionData1,
158162
$expectedOptionData2,
159163
$expectedOptionData3
@@ -208,7 +212,10 @@ public function testResolveSkipsEmptyCustomizableOptions(): void
208212
$this->customizableOptionMock->expects($this->exactly(3))
209213
->method('getData')
210214
->willReturnCallback(
211-
function ($unused, $optionId) use ($expectedOptionData1, $expectedOptionData3) {
215+
function (
216+
QuoteItem $item,
217+
int $optionId
218+
) use ($expectedOptionData1, $expectedOptionData3) {
212219
switch ($optionId) {
213220
case 1:
214221
return $expectedOptionData1;
@@ -281,7 +288,10 @@ public function testResolveHandlesMixedNullAndEmptyArrayReturns(): void
281288
$this->customizableOptionMock->expects($this->exactly(4))
282289
->method('getData')
283290
->willReturnCallback(
284-
function ($unused, $optionId) use ($expectedOptionData1) {
291+
function (
292+
QuoteItem $item,
293+
int $optionId
294+
) use ($expectedOptionData1) {
285295
switch ($optionId) {
286296
case 1:
287297
return $expectedOptionData1;
@@ -430,7 +440,10 @@ public function testResolveHandlesDeletedCustomOption(): void
430440
$this->customizableOptionMock->expects($this->exactly(3))
431441
->method('getData')
432442
->willReturnCallback(
433-
function ($unused, $optionId) use ($validOption1, $validOption2) {
443+
function (
444+
QuoteItem $item,
445+
int $optionId
446+
) use ($validOption1, $validOption2) {
434447
switch ($optionId) {
435448
case 1:
436449
return $validOption1;

0 commit comments

Comments
 (0)