Skip to content

Commit d0bc259

Browse files
committed
LYNX-503 - review comments fixed
1 parent c0d0559 commit d0bc259

File tree

3 files changed

+11
-16
lines changed

3 files changed

+11
-16
lines changed
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
*/
1515
declare(strict_types=1);
1616

17-
namespace Magento\GroupedProductGraphQl\Plugin\CatalogGraphQl\Model\Resolver\Product;
17+
namespace Magento\GroupedProductGraphQl\Plugin\Model\Resolver;
1818

1919
use Magento\CatalogGraphQl\Model\Resolver\Product\ProductImage as Subject;
2020
use Magento\Framework\GraphQl\Config\Element\Field;

app/code/Magento/GroupedProductGraphQl/etc/graphql/di.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,6 @@
5555
</type>
5656

5757
<type name="Magento\CatalogGraphQl\Model\Resolver\Product\ProductImage">
58-
<plugin name="updateThumbnailToParentProductThumbnail" type="Magento\GroupedProductGraphQl\Plugin\CatalogGraphQl\Model\Resolver\Product\ProductImagePlugin" />
58+
<plugin name="updateThumbnailToParentProductThumbnail" type="Magento\GroupedProductGraphQl\Plugin\Model\Resolver\ProductImagePlugin" />
5959
</type>
6060
</config>

dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/AddGroupedProductToCartThumbnailTest.php

Lines changed: 9 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,11 @@ private function assertProductThumbnailUrl(array $thumbnails): void
156156
);
157157
}
158158

159+
/**
160+
* @throws LocalizedException
161+
*/
159162
#[
163+
ConfigFixture('checkout/cart/grouped_product_image', 'itself'),
160164
DataFixture(CategoryFixture::class, ['name' => 'Category'], 'category'),
161165
DataFixture(
162166
ProductFixture::class,
@@ -195,20 +199,11 @@ private function assertProductThumbnailUrl(array $thumbnails): void
195199
]
196200
public function testAddGroupedProductToCartWithoutImageShouldUseThumbnail()
197201
{
198-
$cartId = DataFixtureStorageManager::getStorage()->get('quoteIdMask')->getMaskedId();
199-
$groupedProductId = DataFixtureStorageManager::getStorage()->get('grouped-product')->getSku();
200-
$response = $this->graphQlMutation($this->getMutation($cartId, $groupedProductId));
201-
202-
$this->assertArrayHasKey('addProductsToCart', $response);
203-
$this->assertEquals(2, count($response['addProductsToCart']['cart']['itemsV2']['items']));
204-
$this->assertStringContainsString(
205-
self::DEFAULT_THUMBNAIL_PATH,
206-
$response['addProductsToCart']['cart']['itemsV2']['items'][0]['product']['thumbnail']['url']
207-
);
208-
$this->assertStringContainsString(
209-
self::DEFAULT_THUMBNAIL_PATH,
210-
$response['addProductsToCart']['cart']['itemsV2']['items'][1]['product']['thumbnail']['url']
211-
);
202+
$thumbnails = [
203+
'product1' => self::DEFAULT_THUMBNAIL_PATH,
204+
'product2' => self::DEFAULT_THUMBNAIL_PATH
205+
];
206+
$this->assertProductThumbnailUrl($thumbnails);
212207
}
213208

214209
/**

0 commit comments

Comments
 (0)