Remove formatBasePriceTxt from Order object

Author: kassner

app/code/Magento/Sales/Model/Order.php

@@ -1503,7 +1503,7 @@ public function getItemById($itemId)
      * Get item by quote item id
      *
      * @param mixed $quoteItemId
-     * @return \Magento\Framework\DataObject|null
+     * @return  \Magento\Framework\DataObject|null
      */
     public function getItemByQuoteItemId($quoteItemId)
     {
@@ -1784,17 +1784,6 @@ public function formatBasePricePrecision($price, $precision)
         return $this->getBaseCurrency()->formatPrecision($price, $precision);
     }
 
-    /**
-     * Retrieve text formatted base price value
-     *
-     * @param float $price
-     * @return string
-     */
-    public function formatBasePriceTxt($price)
-    {
-        return $this->getBaseCurrency()->formatTxt($price);
-    }
-
     /**
      * Is currency different
      *

app/code/Magento/Sales/Model/Service/CreditmemoService.php

@@ -202,7 +202,7 @@ protected function validateForRefund(\Magento\Sales\Api\Data\CreditmemoInterface
             throw new \Magento\Framework\Exception\LocalizedException(
                 __(
                     'The most money available to refund is %1.',
-                    $creditmemo->getOrder()->formatBasePriceTxt($baseAvailableRefund)
+                    $creditmemo->getOrder()->getBaseCurrency()->formatTxt($baseAvailableRefund)
                 )
             );
         }

app/code/Magento/Sales/Test/Unit/Model/Service/CreditmemoServiceTest.php

@@ -351,9 +351,14 @@ public function testRefundExpectsMoneyAvailableToReturn()
         $order->method('getBaseTotalPaid')
             ->willReturn($baseTotalPaid);
         $baseAvailableRefund = $baseTotalPaid - $baseTotalRefunded;
-        $order->method('formatBasePriceTxt')
+        $baseCurrency = $this->createMock(\Magento\Directory\Model\Currency::class);
+        $baseCurrency->expects($this->once())
+            ->method('formatTxt')
             ->with($baseAvailableRefund)
             ->willReturn($baseAvailableRefund);
+        $order->expects($this->once())
+            ->method('getBaseCurrency')
+            ->willReturn($baseCurrency);
         $this->creditmemoService->refund($creditMemo, true);
     }
 
@@ -411,9 +416,14 @@ public function testMultiCurrencyRefundExpectsMoneyAvailableToReturn()
         $order->method('getTotalPaid')
             ->willReturn($totalPaid);
         $baseAvailableRefund = $baseTotalPaid - $baseTotalRefunded;
-        $order->method('formatBasePriceTxt')
+        $baseCurrency = $this->createMock(\Magento\Directory\Model\Currency::class);
+        $baseCurrency->expects($this->once())
+            ->method('formatTxt')
             ->with($baseAvailableRefund)
             ->willReturn(sprintf('$%.2f', $baseAvailableRefund));
+        $order->expects($this->once())
+            ->method('getBaseCurrency')
+            ->willReturn($baseCurrency);
         $this->creditmemoService->refund($creditMemo, true);
     }
 }