Skip to content

Commit d4132a5

Browse files
ivy00johnsimeron2433
authored andcommitted
MQE-592: Test Case Audit
- Removing the Robo environment commands. - Adding a Functional command to Robo. - Removing the "skip" group from the CMS test. - Adding the "skip" group to the Configurable Product test.
1 parent 8c5b253 commit d4132a5

File tree

3 files changed

+10
-30
lines changed

3 files changed

+10
-30
lines changed

dev/tests/acceptance/RoboFile.php

Lines changed: 9 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -72,65 +72,45 @@ function generateSuite(array $args)
7272
}
7373

7474
/**
75-
* Run all Functional tests using the Chrome environment.
75+
* Run all Functional tests.
7676
*
7777
* @return void
7878
*/
79-
function chrome()
79+
function functional()
8080
{
81-
$this->_exec('vendor'. DIRECTORY_SEPARATOR .'bin'. DIRECTORY_SEPARATOR .'codecept run functional --env chrome --skip-group skip');
81+
$this->_exec('.' . DIRECTORY_SEPARATOR . 'vendor' . DIRECTORY_SEPARATOR . 'bin' . DIRECTORY_SEPARATOR . 'codecept run functional --skip-group skip');
8282
}
8383

8484
/**
85-
* Run all Functional tests using the FireFox environment.
86-
*
87-
* @return void
88-
*/
89-
function firefox()
90-
{
91-
$this->_exec('vendor'. DIRECTORY_SEPARATOR .'bin'. DIRECTORY_SEPARATOR .'codecept run functional --env firefox --skip-group skip');
92-
}
93-
94-
/**
95-
* Run all Functional tests using the Chrome Headless environment.
96-
*
97-
* @return void
98-
*/
99-
function headless()
100-
{
101-
$this->_exec('vendor'. DIRECTORY_SEPARATOR .'bin'. DIRECTORY_SEPARATOR .'codecept run functional --env headless --skip-group skip');
102-
}
103-
104-
/**
105-
* Run all Tests with the specified @group tag, excluding @group 'skip', using the Chrome environment.
85+
* Run all Tests with the specified @group tag, excluding @group 'skip'.
10686
*
10787
* @param string $args
10888
* @return void
10989
*/
11090
function group($args = '')
11191
{
112-
$this->taskExec('vendor'. DIRECTORY_SEPARATOR .'bin'. DIRECTORY_SEPARATOR .'codecept run functional --verbose --steps --env chrome --skip-group skip --group')->args($args)->run();
92+
$this->taskExec('.' . DIRECTORY_SEPARATOR . 'vendor' . DIRECTORY_SEPARATOR . 'bin' . DIRECTORY_SEPARATOR . 'codecept run functional --verbose --steps --skip-group skip --group')->args($args)->run();
11393
}
11494

11595
/**
116-
* Run all Functional tests located under the Directory Path provided using the Chrome environment.
96+
* Run all Functional tests located under the Directory Path provided.
11797
*
11898
* @param string $args
11999
* @return void
120100
*/
121101
function folder($args = '')
122102
{
123-
$this->taskExec('vendor'. DIRECTORY_SEPARATOR .'bin'. DIRECTORY_SEPARATOR .'codecept run functional --env chrome')->args($args)->run();
103+
$this->taskExec('.' . DIRECTORY_SEPARATOR . 'vendor' . DIRECTORY_SEPARATOR . 'bin' . DIRECTORY_SEPARATOR . 'codecept run functional')->args($args)->run();
124104
}
125105

126106
/**
127-
* Run all Tests marked with the @group tag 'example', using the Chrome environment.
107+
* Run all Tests marked with the @group tag 'example'.
128108
*
129109
* @return void
130110
*/
131111
function example()
132112
{
133-
$this->_exec('vendor'. DIRECTORY_SEPARATOR .'bin'. DIRECTORY_SEPARATOR .'codecept run --env chrome --group example --skip-group skip');
113+
$this->_exec('.' . DIRECTORY_SEPARATOR . 'vendor' . DIRECTORY_SEPARATOR . 'bin' . DIRECTORY_SEPARATOR . 'codecept run --group example --skip-group skip');
134114
}
135115

136116
/**

dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Cms/Cest/AdminCreateCmsPageCest.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
<severity value="CRITICAL"/>
2424
<testCaseId value="MAGETWO-25580"/>
2525
<group value="cms"/>
26-
<group value="skip"/>
2726
</annotations>
2827
<amOnPage url="{{AdminLoginPage.url}}" stepKey="navigateToAdmin"/>
2928
<fillField selector="{{AdminLoginFormSection.username}}" userInput="{{_ENV.MAGENTO_ADMIN_USERNAME}}" stepKey="fillUsername"/>

dev/tests/acceptance/tests/functional/Magento/FunctionalTest/ConfigurableProduct/Cest/AdminCreateConfigurableProductCest.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
<testCaseId value="MAGETWO-26041"/>
2828
<group value="configurable"/>
2929
<group value="product"/>
30+
<group value="skip"/>
3031
</annotations>
3132
<amOnPage url="{{AdminCategoryPage.url}}" stepKey="amOnCategoryGridPage"/>
3233
<waitForPageLoad time="30" stepKey="waitForPageLoad1"/>

0 commit comments

Comments
 (0)