ENGCOM-4752: Disabling "Display on Product Details Page" the button is shown anyway. #22260

Author: sidolov

app/code/Magento/Paypal/Model/SmartButtonConfig.php

@@ -67,7 +67,8 @@ public function getConfig(string $page): array
             'locale' => $this->localeResolver->getLocale(),
             'allowedFunding' => $this->getAllowedFunding($page),
             'disallowedFunding' => $this->getDisallowedFunding(),
-            'styles' => $this->getButtonStyles($page)
+            'styles' => $this->getButtonStyles($page),
+            'isVisibleOnProductPage'  => (int)$this->config->getValue('visible_on_product')
         ];
     }
 

app/code/Magento/Paypal/Test/Unit/Model/_files/expected_config.php

@@ -31,7 +31,8 @@
                 'shape' => 'pillow',
                 'label' => 'installment',
                 'installmentperiod' => 0
-            ]
+            ],
+            'isVisibleOnProductPage' => 0
         ]
     ],
     'checkout' => [
@@ -59,7 +60,8 @@
                 'shape' => 'pillow',
                 'label' => 'installment',
                 'installmentperiod' => 0
-            ]
+            ],
+            'isVisibleOnProductPage' => 0
         ]
     ],
     'mini_cart' => [
@@ -86,7 +88,8 @@
                 'color' => 'gold',
                 'shape' => 'rect',
                 'label' => 'paypal'
-            ]
+            ],
+            'isVisibleOnProductPage' => 0
         ]
     ],
     'mini_cart' => [
@@ -113,7 +116,8 @@
                 'color' => 'gold',
                 'shape' => 'rect',
                 'label' => 'paypal'
-            ]
+            ],
+            'isVisibleOnProductPage' => 0
         ]
     ],
     'product' => [
@@ -140,7 +144,8 @@
                 'color' => 'gold',
                 'shape' => 'rect',
                 'label' => 'paypal',
-            ]
+            ],
+            'isVisibleOnProductPage' => 0
         ]
     ]
 ];

app/code/Magento/Paypal/view/frontend/web/js/in-context/product-express-checkout.js

@@ -24,7 +24,11 @@ define([
                 customer = customerData.get('customer');
 
             this._super();
-            this.renderPayPalButtons(element);
+
+            if (config.clientConfig.isVisibleOnProductPage) {
+                this.renderPayPalButtons(element);
+            }
+
             this.declinePayment = !customer().firstname && !cart().isGuestCheckoutAllowed;
 
             return this;