Skip to content

Commit d6a4106

Browse files
committed
MC-4408: Convert UpdateSimpleProductEntityTest to MFTF
- Use action group to filter product grid
1 parent 361ad62 commit d6a4106

12 files changed

+69
-62
lines changed

app/code/Magento/Catalog/Test/Mftf/Test/AdminUpdateSimpleProductNameToVerifyDataOverridingOnStoreViewLevelTest.xml

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
<group value="mtf_migrated"/>
2020
</annotations>
2121
<before>
22-
<actionGroup ref = "LoginAsAdmin" stepKey="loginAsAdmin"/>
22+
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>
2323
<actionGroup ref="CreateStoreView" stepKey="createCustomStoreViewFr">
2424
<argument name="storeView" value="customStoreFR"/>
2525
</actionGroup>
@@ -44,10 +44,9 @@
4444
<!-- Search default simple product in grid -->
4545
<amOnPage url="{{ProductCatalogPage.url}}" stepKey="OpenProductCatalogPage"/>
4646
<waitForPageLoad stepKey="waitForProductCatalogPage"/>
47-
<conditionalClick selector="{{AdminProductGridFilterSection.clearAll}}" dependentSelector="{{AdminProductGridFilterSection.clearAll}}" visible="true" stepKey="clickClearAllFilter"/>
48-
<fillField selector="{{AdminProductGridFilterSection.keywordSearch}}" userInput="$$initialSimpleProduct.name$$" stepKey="fillSimpleProductNameInKeywordSearch"/>
49-
<click selector="{{AdminProductGridFilterSection.keywordSearchButton}}" stepKey="clickKeywordSearchButton"/>
50-
<waitForPageLoad stepKey="waitForProductSearch"/>
47+
<actionGroup ref="filterProductGridBySku2" stepKey="filterProductGrid">
48+
<argument name="sku" value="$$initialSimpleProduct.sku$$"/>
49+
</actionGroup>
5150
<click selector="{{AdminProductGridFilterSection.nthRow('1')}}" stepKey="clickFirstRowToOpenDefaultSimpleProduct"/>
5251
<waitForPageLoad stepKey="waitUntilProductIsOpened"/>
5352

@@ -57,10 +56,12 @@
5756
<click selector="{{AdminProductFormChangeStoreSection.acceptButton}}" stepKey="clickAcceptButton"/>
5857
<waitForPageLoad stepKey="waitForThePageToLoad"/>
5958
<uncheckOption selector="{{AdminProductFormSection.productNameUseDefault}}" stepKey="uncheckProductStatus"/>
59+
6060
<!-- Update default simple product with name -->
6161
<fillField selector="{{AdminProductFormSection.productName}}" userInput="{{simpleProductDataOverriding.name}}" stepKey="fillSimpleProductName"/>
6262
<click selector="{{AdminProductFormSection.save}}" stepKey="clickSaveButton"/>
6363
<waitForPageLoad stepKey="waitForSimpleProductSave"/>
64+
6465
<!-- Verify customer see success message -->
6566
<see selector="{{AdminProductFormSection.successMessage}}" userInput="You saved the product." stepKey="seeAssertSimpleProductSaveSuccessMessage"/>
6667

app/code/Magento/Catalog/Test/Mftf/Test/AdminUpdateSimpleProductPriceToVerifyDataOverridingOnStoreViewLevelTest.xml

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
<group value="mtf_migrated"/>
2020
</annotations>
2121
<before>
22-
<actionGroup ref = "LoginAsAdmin" stepKey="loginAsAdmin"/>
22+
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>
2323
<actionGroup ref="CreateStoreView" stepKey="createCustomStoreViewFr">
2424
<argument name="storeView" value="customStoreFR"/>
2525
</actionGroup>
@@ -44,21 +44,23 @@
4444
<!-- Search default simple product in grid -->
4545
<amOnPage url="{{ProductCatalogPage.url}}" stepKey="OpenProductCatalogPage"/>
4646
<waitForPageLoad stepKey="waitForProductCatalogPage"/>
47-
<conditionalClick selector="{{AdminProductGridFilterSection.clearAll}}" dependentSelector="{{AdminProductGridFilterSection.clearAll}}" visible="true" stepKey="clickClearAllFilter" />
48-
<fillField selector="{{AdminProductGridFilterSection.keywordSearch}}" userInput="$$initialSimpleProduct.name$$" stepKey="fillSimpleProductNameInKeywordSearch"/>
49-
<click selector="{{AdminProductGridFilterSection.keywordSearchButton}}" stepKey="clickKeywordSearchButton"/>
50-
<waitForPageLoad stepKey="waitForProductSearch"/>
47+
<actionGroup ref="filterProductGridBySku2" stepKey="filterProductGrid">
48+
<argument name="sku" value="$$initialSimpleProduct.sku$$"/>
49+
</actionGroup>
5150
<click selector="{{AdminProductGridFilterSection.nthRow('1')}}" stepKey="clickFirstRowToOpenDefaultSimpleProduct"/>
5251
<waitForPageLoad stepKey="waitUntilProductIsOpened"/>
52+
5353
<!-- Assign simple product to created store view -->
5454
<click selector="{{AdminCategoryMainActionsSection.CategoryStoreViewDropdownToggle}}" stepKey="clickCategoryStoreViewDropdownToggle"/>
5555
<click selector="{{AdminCategoryMainActionsSection.CategoryStoreViewOption(customStoreFR.name)}}" stepKey="selectCategoryStoreViewOption"/>
5656
<click selector="{{AdminProductFormChangeStoreSection.acceptButton}}" stepKey="clickAcceptButton"/>
5757
<waitForPageLoad stepKey="waitForPageToLoad"/>
58+
5859
<!-- Update default simple product with price -->
5960
<fillField selector="{{AdminProductFormSection.productPrice}}" userInput="{{simpleProductDataOverriding.price}}" stepKey="fillSimpleProductPrice"/>
6061
<click selector="{{AdminProductFormSection.save}}" stepKey="clickSaveButton"/>
6162
<waitForPageLoad stepKey="waitForSimpleProductSave"/>
63+
6264
<!-- Verify customer see success message -->
6365
<see selector="{{AdminProductFormSection.successMessage}}" userInput="You saved the product." stepKey="seeAssertSimpleProductSaveSuccessMessage"/>
6466

app/code/Magento/Catalog/Test/Mftf/Test/AdminUpdateSimpleProductTieredPriceTest.xml

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
<group value="mtf_migrated"/>
2020
</annotations>
2121
<before>
22-
<actionGroup ref = "LoginAsAdmin" stepKey="loginAsAdmin"/>
22+
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>
2323
<createData entity="SimpleSubCategory" stepKey="initialCategoryEntity"/>
2424
<createData entity="defaultSimpleProduct" stepKey="initialSimpleProduct">
2525
<requiredEntity createDataKey="initialCategoryEntity"/>
@@ -38,17 +38,17 @@
3838
<!-- Search default simple product in the grid -->
3939
<amOnPage url="{{ProductCatalogPage.url}}" stepKey="OpenProductCatalogPage"/>
4040
<waitForPageLoad stepKey="waitForProductCatalogPage"/>
41-
<conditionalClick selector="{{AdminProductGridFilterSection.clearAll}}" dependentSelector="{{AdminProductGridFilterSection.clearAll}}" visible="true" stepKey="clickClearAllFilter"/>
42-
<fillField selector="{{AdminProductGridFilterSection.keywordSearch}}" userInput="$$initialSimpleProduct.name$$" stepKey="fillSimpleProductNameInKeywordSearch"/>
43-
<click selector="{{AdminProductGridFilterSection.keywordSearchButton}}" stepKey="clickKeywordSearchButton"/>
44-
<waitForPageLoad stepKey="waitForProductSearch"/>
41+
<actionGroup ref="filterProductGridBySku2" stepKey="filterProductGrid">
42+
<argument name="sku" value="$$initialSimpleProduct.sku$$"/>
43+
</actionGroup>
4544
<click selector="{{AdminProductGridFilterSection.nthRow('1')}}" stepKey="clickFirstRowToOpenDefaultSimpleProduct"/>
4645
<waitForPageLoad stepKey="waitUntilProductIsOpened"/>
4746

4847
<!-- Update simple product with tier price(in stock) -->
4948
<fillField selector="{{AdminProductFormSection.productName}}" userInput="{{simpleProductTierPrice300InStock.name}}" stepKey="fillSimpleProductName"/>
5049
<fillField selector="{{AdminProductFormSection.productSku}}" userInput="{{simpleProductTierPrice300InStock.sku}}" stepKey="fillSimpleProductSku"/>
5150
<fillField selector="{{AdminProductFormSection.productPrice}}" userInput="{{simpleProductTierPrice300InStock.price}}" stepKey="fillSimpleProductPrice"/>
51+
5252
<!-- Press enter to validate advanced pricing link -->
5353
<pressKey selector="{{AdminProductFormSection.productPrice}}" parameterArray="[\Facebook\WebDriver\WebDriverKeys::ENTER]" stepKey="pressEnterKey"/>
5454
<click selector="{{AdminProductFormSection.advancedPricingLink}}" stepKey="clickAdvancedPricingLink"/>
@@ -74,6 +74,7 @@
7474
<scrollToTopOfPage stepKey="scrollToTopOfAdminProductFormSection"/>
7575
<click selector="{{AdminProductFormSection.save}}" stepKey="clickSaveButton"/>
7676
<waitForPageLoad stepKey="waitForSimpleProductSave"/>
77+
7778
<!-- Verify customer see success message -->
7879
<see selector="{{AdminProductFormSection.successMessage}}" userInput="You saved the product." stepKey="seeAssertSimpleProductSaveSuccessMessage"/>
7980

app/code/Magento/Catalog/Test/Mftf/Test/AdminUpdateSimpleProductWithRegularPriceInStockDisabledProductTest.xml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
<group value="mtf_migrated"/>
2020
</annotations>
2121
<before>
22-
<actionGroup ref = "LoginAsAdmin" stepKey="loginAsAdmin"/>
22+
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>
2323
<createData entity="SimpleSubCategory" stepKey="initialCategoryEntity"/>
2424
<createData entity="defaultSimpleProduct" stepKey="initialSimpleProduct">
2525
<requiredEntity createDataKey="initialCategoryEntity"/>
@@ -36,10 +36,9 @@
3636
<!-- Search default simple product in the grid page -->
3737
<amOnPage url="{{ProductCatalogPage.url}}" stepKey="OpenProductCatalogPage"/>
3838
<waitForPageLoad stepKey="waitForProductCatalogPage"/>
39-
<conditionalClick selector="{{AdminProductGridFilterSection.clearAll}}" dependentSelector="{{AdminProductGridFilterSection.clearAll}}" visible="true" stepKey="clickClearAllFilter"/>
40-
<fillField selector="{{AdminProductGridFilterSection.keywordSearch}}" userInput="$$initialSimpleProduct.name$$" stepKey="fillSimpleProductNameInKeywordSearch"/>
41-
<click selector="{{AdminProductGridFilterSection.keywordSearchButton}}" stepKey="clickKeywordSearchButton"/>
42-
<waitForPageLoad stepKey="waitForProductSearch"/>
39+
<actionGroup ref="filterProductGridBySku2" stepKey="filterProductGrid">
40+
<argument name="sku" value="$$initialSimpleProduct.sku$$"/>
41+
</actionGroup>
4342
<click selector="{{AdminProductGridFilterSection.nthRow('1')}}" stepKey="clickFirstRowToOpenDefaultSimpleProduct"/>
4443
<waitForPageLoad stepKey="waitUntilProductIsOpened"/>
4544

@@ -56,6 +55,7 @@
5655
<click selector="{{AdminProductFormSection.enableProductLabel}}" stepKey="clickEnableProductLabelToDisableProduct"/>
5756
<click selector="{{AdminProductFormSection.save}}" stepKey="clickSaveButton"/>
5857
<waitForPageLoad stepKey="waitForSimpleProductSave"/>
58+
5959
<!-- Verify customer see success message -->
6060
<see selector="{{AdminProductFormSection.successMessage}}" userInput="You saved the product." stepKey="seeAssertSimpleProductSaveSuccessMessage"/>
6161

app/code/Magento/Catalog/Test/Mftf/Test/AdminUpdateSimpleProductWithRegularPriceInStockEnabledFlatTest.xml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
<group value="mtf_migrated"/>
2020
</annotations>
2121
<before>
22-
<actionGroup ref = "LoginAsAdmin" stepKey="loginAsAdmin"/>
22+
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>
2323
<magentoCLI stepKey="setFlatCatalogProduct" command="config:set catalog/frontend/flat_catalog_product 1"/>
2424
<createData entity="SimpleSubCategory" stepKey="initialCategoryEntity"/>
2525
<createData entity="defaultSimpleProduct" stepKey="initialSimpleProduct">
@@ -40,10 +40,9 @@
4040
<!-- Search default simple product in the grid page -->
4141
<amOnPage url="{{ProductCatalogPage.url}}" stepKey="OpenProductCatalogPage"/>
4242
<waitForPageLoad stepKey="waitForProductCatalogPage"/>
43-
<conditionalClick selector="{{AdminProductGridFilterSection.clearAll}}" dependentSelector="{{AdminProductGridFilterSection.clearAll}}" visible="true" stepKey="clickClearAllFilter" />
44-
<fillField selector="{{AdminProductGridFilterSection.keywordSearch}}" userInput="$$initialSimpleProduct.name$$" stepKey="fillSimpleProductNameInKeywordSearch"/>
45-
<click selector="{{AdminProductGridFilterSection.keywordSearchButton}}" stepKey="clickKeywordSearchButton"/>
46-
<waitForPageLoad stepKey="waitForProductSearch"/>
43+
<actionGroup ref="filterProductGridBySku2" stepKey="filterProductGrid">
44+
<argument name="sku" value="$$initialSimpleProduct.sku$$"/>
45+
</actionGroup>
4746
<click selector="{{AdminProductGridFilterSection.nthRow('1')}}" stepKey="clickFirstRowToOpenDefaultSimpleProduct"/>
4847
<waitForPageLoad stepKey="waitUntilProductIsOpened"/>
4948

@@ -73,6 +72,7 @@
7372
<scrollToTopOfPage stepKey="scrollToTopOfAdminProductFormSection"/>
7473
<click selector="{{AdminProductFormSection.save}}" stepKey="clickSaveButton"/>
7574
<waitForPageLoad stepKey="waitForSimpleProductSave"/>
75+
7676
<!-- Verify customer see success message -->
7777
<see selector="{{AdminProductFormSection.successMessage}}" userInput="You saved the product." stepKey="seeAssertSimpleProductSaveSuccessMessage"/>
7878

app/code/Magento/Catalog/Test/Mftf/Test/AdminUpdateSimpleProductWithRegularPriceInStockNotVisibleIndividuallyTest.xml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
<group value="mtf_migrated"/>
2020
</annotations>
2121
<before>
22-
<actionGroup ref = "LoginAsAdmin" stepKey="loginAsAdmin"/>
22+
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>
2323
<createData entity="SimpleSubCategory" stepKey="initialCategoryEntity"/>
2424
<createData entity="defaultSimpleProduct" stepKey="initialSimpleProduct">
2525
<requiredEntity createDataKey="initialCategoryEntity"/>
@@ -38,10 +38,9 @@
3838
<!-- Search default simple product in the grid page -->
3939
<amOnPage url="{{ProductCatalogPage.url}}" stepKey="OpenProductCatalogPage"/>
4040
<waitForPageLoad stepKey="waitForProductCatalogPage"/>
41-
<conditionalClick selector="{{AdminProductGridFilterSection.clearAll}}" dependentSelector="{{AdminProductGridFilterSection.clearAll}}" visible="true" stepKey="clickClearAllFilter" />
42-
<fillField selector="{{AdminProductGridFilterSection.keywordSearch}}" userInput="$$initialSimpleProduct.name$$" stepKey="fillSimpleProductNameInKeywordSearch"/>
43-
<click selector="{{AdminProductGridFilterSection.keywordSearchButton}}" stepKey="clickKeywordSearchButton"/>
44-
<waitForPageLoad stepKey="waitForProductSearch"/>
41+
<actionGroup ref="filterProductGridBySku2" stepKey="filterProductGrid">
42+
<argument name="sku" value="$$initialSimpleProduct.sku$$"/>
43+
</actionGroup>
4544
<click selector="{{AdminProductGridFilterSection.nthRow('1')}}" stepKey="clickFirstRowToOpenDefaultSimpleProduct"/>
4645
<waitForPageLoad stepKey="waitUntilProductIsOpened"/>
4746

@@ -64,6 +63,7 @@
6463
<scrollToTopOfPage stepKey="scrollToTopOfAdminProductFormSection"/>
6564
<click selector="{{AdminProductFormSection.save}}" stepKey="clickSaveButton"/>
6665
<waitForPageLoad stepKey="waitForSimpleProductSave"/>
66+
6767
<!-- Verify customer see success message -->
6868
<see selector="{{AdminProductFormSection.successMessage}}" userInput="You saved the product." stepKey="seeAssertSimpleProductSaveSuccessMessage"/>
6969

app/code/Magento/Catalog/Test/Mftf/Test/AdminUpdateSimpleProductWithRegularPriceInStockUnassignFromCategoryTest.xml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
<group value="mtf_migrated"/>
2020
</annotations>
2121
<before>
22-
<actionGroup ref = "LoginAsAdmin" stepKey="loginAsAdmin"/>
22+
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>
2323
<createData entity="SimpleSubCategory" stepKey="initialCategoryEntity"/>
2424
<createData entity="_defaultProduct" stepKey="initialSimpleProduct">
2525
<requiredEntity createDataKey="initialCategoryEntity"/>
@@ -36,10 +36,9 @@
3636
<!--Search default simple product in the grid page -->
3737
<amOnPage url="{{ProductCatalogPage.url}}" stepKey="OpenProductCatalogPage"/>
3838
<waitForPageLoad stepKey="waitForProductCatalogPage"/>
39-
<conditionalClick selector="{{AdminProductGridFilterSection.clearAll}}" dependentSelector="{{AdminProductGridFilterSection.clearAll}}" visible="true" stepKey="clickClearAllFilter" />
40-
<fillField selector="{{AdminProductGridFilterSection.keywordSearch}}" userInput="$$initialSimpleProduct.name$$" stepKey="fillDefaultSimpleProductName"/>
41-
<click selector="{{AdminProductGridFilterSection.keywordSearchButton}}" stepKey="clickKeywordSearchButton"/>
42-
<waitForPageLoad stepKey="waitForProductSearch"/>
39+
<actionGroup ref="filterProductGridBySku2" stepKey="filterProductGrid">
40+
<argument name="sku" value="$$initialSimpleProduct.sku$$"/>
41+
</actionGroup>
4342
<click selector="{{AdminProductGridFilterSection.nthRow('1')}}" stepKey="clickFirstRowToOpenDefaultSimpleProduct"/>
4443
<waitForPageLoad stepKey="waitUntilProductIsOpened"/>
4544

@@ -51,6 +50,7 @@
5150
<scrollToTopOfPage stepKey="scrollToTopOfAdminProductFormSection"/>
5251
<click selector="{{AdminProductFormSection.save}}" stepKey="clickSaveButton"/>
5352
<waitForPageLoad stepKey="waitForSimpleProductSave"/>
53+
5454
<!-- Verify customer see success message -->
5555
<see selector="{{AdminProductFormSection.successMessage}}" userInput="You saved the product." stepKey="seeAssertSimpleProductSaveSuccessMessage"/>
5656

app/code/Magento/Catalog/Test/Mftf/Test/AdminUpdateSimpleProductWithRegularPriceInStockVisibleInCatalogAndSearchTest.xml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
<group value="mtf_migrated"/>
2020
</annotations>
2121
<before>
22-
<actionGroup ref = "LoginAsAdmin" stepKey="loginAsAdmin"/>
22+
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>
2323
<createData entity="SimpleSubCategory" stepKey="initialCategoryEntity"/>
2424
<createData entity="defaultSimpleProduct" stepKey="initialSimpleProduct">
2525
<requiredEntity createDataKey="initialCategoryEntity"/>
@@ -38,10 +38,9 @@
3838
<!-- Search default simple product in the grid page -->
3939
<amOnPage url="{{ProductCatalogPage.url}}" stepKey="OpenProductCatalogPage"/>
4040
<waitForPageLoad stepKey="waitForProductCatalogPage"/>
41-
<conditionalClick selector="{{AdminProductGridFilterSection.clearAll}}" dependentSelector="{{AdminProductGridFilterSection.clearAll}}" visible="true" stepKey="clickClearAllFilter" />
42-
<fillField selector="{{AdminProductGridFilterSection.keywordSearch}}" userInput="$$initialSimpleProduct.name$$" stepKey="fillSimpleProductNameInKeywordSearch"/>
43-
<click selector="{{AdminProductGridFilterSection.keywordSearchButton}}" stepKey="clickKeywordSearchButton"/>
44-
<waitForPageLoad stepKey="waitForProductSearch"/>
41+
<actionGroup ref="filterProductGridBySku2" stepKey="filterProductGrid">
42+
<argument name="sku" value="$$initialSimpleProduct.sku$$"/>
43+
</actionGroup>
4544
<click selector="{{AdminProductGridFilterSection.nthRow('1')}}" stepKey="clickFirstRowToOpenDefaultSimpleProduct"/>
4645
<waitForPageLoad stepKey="waitUntilProductIsOpened"/>
4746

@@ -64,6 +63,7 @@
6463
<scrollToTopOfPage stepKey="scrollToTopOfAdminProductFormSection"/>
6564
<click selector="{{AdminProductFormSection.save}}" stepKey="clickSaveButton"/>
6665
<waitForPageLoad stepKey="waitForSimpleProductSave"/>
66+
6767
<!-- Verify customer see success message -->
6868
<see selector="{{AdminProductFormSection.successMessage}}" userInput="You saved the product." stepKey="seeAssertSimpleProductSaveSuccessMessage"/>
6969

0 commit comments

Comments
 (0)