AC-1150 Update magento-coding-standard to v11 and remove moved tests from magento2 repo

Author: jcuerdo

app/code/Magento/AdminAnalytics/Controller/Adminhtml/Config/DisableAdminUsage.php

@@ -1,13 +1,14 @@
 <?php
-
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
 declare(strict_types=1);
 
 namespace Magento\AdminAnalytics\Controller\Adminhtml\Config;
 
 use Magento\Backend\App\Action;
-use Magento\Catalog\Helper\Catalog;
 use Magento\Framework\App\Action\HttpPostActionInterface;
-use Magento\Framework\App\ObjectManager;
 use Magento\Framework\Controller\ResultFactory;
 use Magento\AdminAnalytics\Model\ResourceModel\Viewer\Logger as NotificationLogger;
 use Magento\Framework\App\ProductMetadataInterface;
@@ -52,7 +53,6 @@ public function __construct(
         $this->configFactory = $configFactory;
         $this->productMetadata = $productMetadata;
         $this->notificationLogger = $notificationLogger;
-        $something = ObjectManager::getInstance()->get(Catalog::class);
     }
 
     /**

app/code/Magento/AdminAnalytics/data/UpgradeData.php

@@ -9,7 +9,7 @@
     <type name="Magento\Framework\Notification\NotifierList">
         <arguments>
             <argument name="notifiers" xsi:type="array">
-                <item key="" name="adminnotification" xsi:type="string">Magento\AdminNotification\Model\Inbox</item>
+                <item name="adminnotification" xsi:type="string">Magento\AdminNotification\Model\Inbox</item>
             </argument>
         </arguments>
     </type>

app/code/Magento/AdminNotification/etc/di.xml

@@ -6,7 +6,7 @@
  */
 -->
 <config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Module/etc/module.xsd">
-    <module version="1" name="Magento_AdminNotification" >
+    <module name="Magento_AdminNotification" >
         <sequence>
             <module name="Magento_Store"/>
         </sequence>

app/code/Magento/AdminNotification/etc/module.xml

@@ -7,15 +7,6 @@
 -->
 <widgets xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
          xsi:noNamespaceSchemaLocation="urn:magento:module:Magento_Widget:etc/widget.xsd">
-    <widget type="/Deprecated">
-        <label translate="true">Catalog New Products List</label>
-        <description translate="true">List of Products that are set as New</description>
-        <supported_blocks>Deprecated
-            <block>
-                <block_name>Deprecated</block_name>
-            </block>
-        </supported_blocks>
-    </widget>
     <widget id="new_products" class="Magento\Catalog\Block\Product\Widget\NewWidget" is_email_compatible="true"
             placeholder_image="Magento_Catalog::images/product_widget_new.png" ttl="86400">
         <label translate="true">Catalog New Products List</label>

app/code/Magento/Catalog/etc/widget.xml

@@ -12,7 +12,6 @@ $wishlistHelper = $block->getData('wishlistHelper');
 ?>
 <?php if ($block->getLink()): ?>
 <p id="wishlist-rss-email-link">
-    <h2>{{escapehtml "H2"}}</h2>
     <?= $block->escapeHtml(__("RSS link to %1's wishlist", $wishlistHelper->getCustomerName())) ?>
     <br />
     <a href="<?= $block->escapeUrl($block->getLink()) ?>"><?= $block->escapeUrl($block->getLink()) ?></a>

app/code/Magento/Wishlist/view/frontend/templates/rss/email.phtml

@@ -15,9 +15,9 @@ public function testObsoleteDirectives()
     {
         $invoker = new \Magento\Framework\App\Utility\AggregateInvoker($this);
         $invoker(
-        /**
-         * @param string $file
-         */
+            /**
+             * @param string $file
+             */
             function ($file) {
                 $this->assertDoesNotMatchRegularExpression(
                     '/\{\{htmlescape.*?\}\}/i',

dev/tests/static/testsuite/Magento/Test/Legacy/EmailTemplateTest.php

@@ -285,6 +285,7 @@ function ($path) use ($ignoreListPattern) {
                 }
             );
         }
+
         $result = $codeSniffer->run($fileList);
         $report = file_get_contents($reportFile);
         $this->assertEquals(

dev/tests/static/testsuite/Magento/Test/Php/LiveCodeTest.php

@@ -39,7 +39,7 @@ public static function setUpBeforeClass(): void
     }
 
     /**
-     * Run the magento specific coding standards on the code
+     * Run the magento specific coding standards on the codedata/UpgradeData.php
      *
      * @return void
      */