Merge branch 'ACP2E-1505' of https://github.com/magento-l3/magento2ce into PR-01-10-2023

Author: chittima

app/code/Magento/Catalog/Setup/Patch/Data/UpdateMultiselectAttributesBackendTypes.php

@@ -81,15 +81,18 @@ public function apply()
             ->select()
             ->from($varcharTable)
             ->where('attribute_id in (?)', $attributesToMigrate);
-        $dataToMigrate = array_map(static function ($row) {
-            $row['value_id'] = null;
-            return $row;
-        }, $connection->fetchAll($varcharTableDataSql));
-
-        foreach (array_chunk($dataToMigrate, 2000) as $dataChunk) {
-            $connection->insertMultiple($textTable, $dataChunk);
-        }
 
+        $columns = $connection->describeTable($varcharTable);
+        unset($columns['value_id']);
+        $connection->query(
+            $connection->insertFromSelect(
+                $connection->select()
+                    ->from($varcharTable, array_keys($columns))
+                    ->where('attribute_id in (?)', $attributesToMigrate),
+                $textTable,
+                array_keys($columns)
+            )
+        );
         $connection->query($connection->deleteFromSelect($varcharTableDataSql, $varcharTable));
 
         foreach ($attributesToMigrate as $attributeId) {

app/code/Magento/Catalog/Test/Unit/Setup/Patch/Data/UpdateMultiselectAttributesBackendTypesTest.php

@@ -0,0 +1,114 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+declare(strict_types=1);
+
+namespace Magento\Catalog\Test\Unit\Setup\Patch\Data;
+
+use Magento\Catalog\Setup\Patch\Data\UpdateMultiselectAttributesBackendTypes;
+use Magento\Eav\Setup\EavSetup;
+use Magento\Eav\Setup\EavSetupFactory;
+use Magento\Framework\DB\Adapter\AdapterInterface;
+use Magento\Framework\DB\Select;
+use Magento\Framework\Setup\ModuleDataSetupInterface;
+use PHPUnit\Framework\TestCase;
+
+class UpdateMultiselectAttributesBackendTypesTest extends TestCase
+{
+    /**
+     * @var ModuleDataSetupInterface|\PHPUnit\Framework\MockObject\MockObject
+     */
+    private $dataSetup;
+
+    /**
+     * @var EavSetupFactory|\PHPUnit\Framework\MockObject\MockObject
+     */
+    private $eavSetupFactory;
+
+    /**
+     * @var UpdateMultiselectAttributesBackendTypes
+     */
+    private $model;
+
+    /**
+     * @inheritdoc
+     */
+    protected function setUp(): void
+    {
+        parent::setUp();
+        $this->dataSetup = $this->createMock(ModuleDataSetupInterface::class);
+        $this->eavSetupFactory = $this->createMock(EavSetupFactory::class);
+        $this->model = new UpdateMultiselectAttributesBackendTypes($this->dataSetup, $this->eavSetupFactory);
+    }
+
+    public function testApply(): void
+    {
+        $attributeIds = [3, 7];
+        $entityTypeId = 4;
+        $eavSetup = $this->createMock(EavSetup::class);
+        $connection = $this->createMock(AdapterInterface::class);
+        $select1 = $this->createMock(Select::class);
+        $select2 = $this->createMock(Select::class);
+        $select3 = $this->createMock(Select::class);
+        $this->eavSetupFactory->method('create')
+            ->willReturn($eavSetup);
+        $this->dataSetup->method('getConnection')
+            ->willReturn($connection);
+        $this->dataSetup->method('getTable')
+            ->willReturnArgument(0);
+        $eavSetup->method('getEntityTypeId')
+            ->willReturn(4);
+        $eavSetup->method('updateAttribute')
+            ->withConsecutive(
+                [$entityTypeId, 3, 'backend_type', 'text'],
+                [$entityTypeId, 7, 'backend_type', 'text']
+            );
+        $connection->expects($this->exactly(3))
+            ->method('select')
+            ->willReturnOnConsecutiveCalls($select1, $select2, $select3);
+        $connection->method('describeTable')
+            ->willReturn(
+                [
+                    'value_id' => [],
+                    'attribute_id' => [],
+                    'store_id' => [],
+                    'value' => [],
+                    'row_id' => [],
+                ]
+            );
+        $connection->method('fetchCol')
+            ->with($select1)
+            ->willReturn($attributeIds);
+        $connection->method('insertFromSelect')
+            ->with($select3, 'catalog_product_entity_text', ['attribute_id', 'store_id', 'value', 'row_id'])
+            ->willReturn('');
+        $connection->method('deleteFromSelect')
+            ->with($select2, 'catalog_product_entity_varchar')
+            ->willReturn('');
+        $select1->method('from')
+            ->with('eav_attribute', ['attribute_id'])
+            ->willReturnSelf();
+        $select1->method('where')
+            ->withConsecutive(
+                ['entity_type_id = ?', $entityTypeId],
+                ['backend_type = ?', 'varchar'],
+                ['frontend_input = ?', 'multiselect']
+            )
+            ->willReturnSelf();
+        $select2->method('from')
+            ->with('catalog_product_entity_varchar')
+            ->willReturnSelf();
+        $select2->method('where')
+            ->with('attribute_id in (?)', $attributeIds)
+            ->willReturnSelf();
+        $select3->method('from')
+            ->with('catalog_product_entity_varchar', ['attribute_id', 'store_id', 'value', 'row_id'])
+            ->willReturnSelf();
+        $select3->method('where')
+            ->with('attribute_id in (?)', $attributeIds)
+            ->willReturnSelf();
+        $this->model->apply();
+    }
+}