Skip to content

Commit d9000c3

Browse files
committed
B2B-1912: Flaky Action Group AdminCreateWidgetActionGroup
- Fixing flaky actiongroup - Moving actions that do not belong in actiongroup to separate test
1 parent 866a7f0 commit d9000c3

File tree

2 files changed

+12
-8
lines changed

2 files changed

+12
-8
lines changed

app/code/Magento/Widget/Test/Mftf/ActionGroup/AdminCreateWidgetActionGroup.xml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,12 @@
2020
<selectOption selector="{{AdminNewWidgetSection.widgetType}}" userInput="{{widget.type}}" stepKey="setWidgetType"/>
2121
<selectOption selector="{{AdminNewWidgetSection.widgetDesignTheme}}" userInput="{{widget.design_theme}}" stepKey="setWidgetDesignTheme"/>
2222
<click selector="{{AdminNewWidgetSection.continue}}" stepKey="clickContinue"/>
23-
<waitForPageLoad stepKey="waitForPageLoadAfterClickingContinue"/>
23+
<waitForPageLoad stepKey="waitForContinue"/>
24+
<waitForElementVisible selector="{{AdminNewWidgetSection.widgetTitle}}" stepKey="waitForTitle"/>
2425
<fillField selector="{{AdminNewWidgetSection.widgetTitle}}" userInput="{{widget.name}}" stepKey="fillTitle"/>
2526
<selectOption selector="{{AdminNewWidgetSection.widgetStoreIds}}" userInput="{{widget.store_ids[0]}}" stepKey="setWidgetStoreIds"/>
2627
<click selector="{{AdminNewWidgetSection.addLayoutUpdate}}" stepKey="clickAddLayoutUpdate"/>
27-
<waitForPageLoad stepKey="waitForPageLoadAfterClickingAddLayoutUpdate"/>
28+
<waitForElementVisible selector="{{AdminNewWidgetSection.selectDisplayOn}}" stepKey="waitForLayoutUpdate"/>
2829
<comment userInput="BIC workaround" stepKey="clickAddLayoutUpdate2"/>
2930
<comment userInput="BIC workaround" stepKey="seeTwoLayoutUpdates"/>
3031
<comment userInput="BIC workaround" stepKey="clickRemoveLastLayoutUpdate"/>
@@ -35,6 +36,6 @@
3536
<waitForPageLoad stepKey="waitForPageLoad"/>
3637
<scrollToTopOfPage stepKey="scrollToTopOfPage"/>
3738
<click selector="{{AdminNewWidgetSection.widgetOptions}}" stepKey="clickWidgetOptions"/>
38-
<waitForPageLoad stepKey="waitForPageLoadAfterClickingWidgetOptions"/>
39+
<waitForPageLoad stepKey="waitForWidgetOptions"/>
3940
</actionGroup>
4041
</actionGroups>

app/code/Magento/Widget/Test/Mftf/Test/AdminWidgetAddAndDeleteMultipleLayoutSectionsTest.xml

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,18 +28,21 @@
2828
<actionGroup ref="AdminAssertPageTitleActionGroup" stepKey="seePageTitleFirst">
2929
<argument name="title" value="{{AdminMenuContentElementsWidgets.pageTitle}}"/>
3030
</actionGroup>
31-
<waitForLoadingMaskToDisappear stepKey="waitForLoadingMaskToDisappear1"/>
31+
<waitForPageLoad stepKey="waitForLoadingMaskToDisappear1"/>
3232
<actionGroup ref="AdminCreateWidgetWthoutLayoutActionGroup" stepKey="addWidgetForTest">
3333
<argument name="widget" value="ProductsListWidget"/>
3434
</actionGroup>
3535
<actionGroup ref="AdminWidgetAddLayoutUpdateActionGroup" stepKey="AddSecondLayout"/>
36+
<click selector="{{AdminNewWidgetSection.removeLastLayoutUpdate}}" stepKey="clickRemoveLastLayoutUpdate"/>
37+
<seeNumberOfElements userInput="1" selector="{{AdminNewWidgetSection.layoutUpdate}}" stepKey="seeOneLayoutUpdate"/>
38+
<actionGroup ref="AdminWidgetAddLayoutUpdateActionGroup" stepKey="AddSecondLayoutAgain"/>
3639
<actionGroup ref="AdminWidgetAddLayoutUpdateActionGroup" stepKey="AddThirdLayout"/>
3740
<seeNumberOfElements userInput="3" selector="{{AdminNewWidgetSection.CountDeleteButtons}}" stepKey="seeThreeDeleteButtons"/>
38-
<actionGroup ref="AdminWidgetDeleteLayoutUpdateActionGroup" stepKey="DeleteFirstLayoutForWidget"></actionGroup>
41+
<actionGroup ref="AdminWidgetDeleteLayoutUpdateActionGroup" stepKey="DeleteFirstLayoutForWidget"/>
3942
<seeNumberOfElements userInput="2" selector="{{AdminNewWidgetSection.CountDeleteButtons}}" stepKey="seeTwoDeleteButtons"/>
40-
<actionGroup ref="AdminWidgetDeleteLayoutUpdateActionGroup" stepKey="DeleteSecondLayoutForWidget"></actionGroup>
43+
<actionGroup ref="AdminWidgetDeleteLayoutUpdateActionGroup" stepKey="DeleteSecondLayoutForWidget"/>
4144
<seeNumberOfElements userInput="1" selector="{{AdminNewWidgetSection.CountDeleteButtons}}" stepKey="seeOneDeleteButtons"/>
42-
<actionGroup ref="AdminWidgetDeleteLayoutUpdateActionGroup" stepKey="DeleteThirdLayoutForWidget"></actionGroup>
45+
<actionGroup ref="AdminWidgetDeleteLayoutUpdateActionGroup" stepKey="DeleteThirdLayoutForWidget"/>
4346
<seeNumberOfElements userInput="0" selector="{{AdminNewWidgetSection.CountDeleteButtons}}" stepKey="seeZeroDeleteButtons"/>
4447
</test>
45-
</tests>
48+
</tests>

0 commit comments

Comments
 (0)