ACP2E-2098: avoid loading all attribute collection

Author: alzota

app/code/Magento/QuoteGraphQl/Plugin/ProductAttributesExtender.php

@@ -8,7 +8,10 @@
 namespace Magento\QuoteGraphQl\Plugin;
 
 use Magento\Catalog\Model\ResourceModel\Product\Attribute\CollectionFactory as AttributeCollectionFactory;
+use Magento\Eav\Model\Validator\Attribute\Code;
+use Magento\Framework\App\ObjectManager;
 use Magento\Framework\GraphQl\Query\Fields;
+use Magento\Framework\Validator\ValidateException;
 use Magento\Quote\Model\Quote\Config as QuoteConfig;
 
 /**
@@ -26,16 +29,44 @@ class ProductAttributesExtender
      */
     private $attributeCollectionFactory;
 
+    /**
+     * @var Code
+     */
+    private Code $attributeCodeValidator;
+
     /**
      * @param Fields $fields
      * @param AttributeCollectionFactory $attributeCollectionFactory
+     * @param Code|null $attributeCodeValidator
      */
     public function __construct(
         Fields $fields,
-        AttributeCollectionFactory $attributeCollectionFactory
+        AttributeCollectionFactory $attributeCollectionFactory,
+        Code $attributeCodeValidator = null
     ) {
         $this->fields = $fields;
         $this->attributeCollectionFactory = $attributeCollectionFactory;
+        $this->attributeCodeValidator = $attributeCodeValidator ?? ObjectManager::getInstance()->get(Code::class);
+    }
+
+    /**
+     * Get only attribute code that pass validation
+     *
+     * @return array
+     */
+    private function getValidatedAttributeCodes(): array
+    {
+        return array_filter($this->fields->getFieldsUsedInQuery(), [$this,'validateAttributeCode']);
+    }
+
+    /**
+     * @param string|int $code
+     * @return bool
+     * @throws ValidateException
+     */
+    private function validateAttributeCode(string|int $code)
+    {
+        return $this->attributeCodeValidator->isValid((string)$code);
     }
 
     /**
@@ -51,7 +82,7 @@ public function afterGetProductAttributes(QuoteConfig $subject, array $result):
         $attributeCollection = $this->attributeCollectionFactory->create()
             ->removeAllFieldsFromSelect()
             ->addFieldToSelect('attribute_code')
-            ->setCodeFilter($this->fields->getFieldsUsedInQuery())
+            ->setCodeFilter($this->getValidatedAttributeCodes())
             ->load();
         $attributes = $attributeCollection->getColumnValues('attribute_code');