PHPUnit 10 static test fixes

Author: nishant04412

app/code/Magento/Authorization/Test/Unit/Model/ResourceModel/RulesTest.php

@@ -35,7 +35,7 @@ class RulesTest extends TestCase
     /**
      * Test constants
      */
-    public const TEST_ROLE_ID = 13;
+    private const TEST_ROLE_ID = 13;
 
     /**
      * @var Rules

app/code/Magento/Catalog/Test/Unit/Model/Product/Attribute/Backend/StockTest.php

@@ -18,7 +18,7 @@
 
 class StockTest extends TestCase
 {
-    public const ATTRIBUTE_NAME = 'quantity_and_stock_status';
+    private const ATTRIBUTE_NAME = 'quantity_and_stock_status';
 
     /**
      * @var Stock

app/code/Magento/Catalog/Test/Unit/Model/ResourceModel/Category/FlatTest.php

@@ -25,12 +25,12 @@
  */
 class FlatTest extends TestCase
 {
-    public const STORE_ID = 1;
-    public const TABLE_NAME = 'test_table';
-    public const PARENT_PATH = '1';
-    public const SORTED = false;
-    public const PARENT = 1;
-    public const RECURSION_LEVEL = 0;
+    private const STORE_ID = 1;
+    private const TABLE_NAME = 'test_table';
+    private const PARENT_PATH = '1';
+    private const SORTED = false;
+    private const PARENT = 1;
+    private const RECURSION_LEVEL = 0;
 
     /**
      * @var CollectionFactory|MockObject

app/code/Magento/Catalog/Test/Unit/Model/ResourceModel/Product/GalleryTest.php

@@ -332,6 +332,7 @@ public function testBindValueToEntityRecordExists(): void
 
     /**
      * @return void
+     * @SuppressWarnings(PHPMD.CyclomaticComplexity)
      * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
      */
     public function testLoadGallery(): void

app/code/Magento/Catalog/Test/Unit/Ui/Component/Listing/Columns/AttributeSetTextTest.php

@@ -14,8 +14,8 @@
 
 class AttributeSetTextTest extends AbstractColumnTestCase
 {
-    public const ATTRIBUTE_SET_ID = 4;
-    public const ATTRIBUTE_SET_NAME = 'Default';
+    private const ATTRIBUTE_SET_ID = 4;
+    private const ATTRIBUTE_SET_NAME = 'Default';
 
     /**
      * @var AttributeSetRepositoryInterface|MockObject

app/code/Magento/Catalog/Test/Unit/Ui/Component/Listing/Columns/StatusTextTest.php

@@ -14,8 +14,8 @@
 
 class StatusTextTest extends AbstractColumnTestCase
 {
-    public const STATUS_ID = 1;
-    public const STATUS_TEXT = 'Enabled';
+    private const STATUS_ID = 1;
+    private const STATUS_TEXT = 'Enabled';
 
     /**
      * @var Status|MockObject

app/code/Magento/CatalogInventory/Test/Unit/Model/Stock/StockItemRepositoryTest.php

@@ -34,6 +34,7 @@
 use PHPUnit\Framework\TestCase;
 
 /**
+ * @SuppressWarnings(PHPMD.TooManyFields)
  * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class StockItemRepositoryTest extends TestCase

app/code/Magento/ConfigurableProduct/Test/Unit/Model/Product/Type/Collection/SalableProcessorTest.php

@@ -18,7 +18,7 @@
 
 class SalableProcessorTest extends TestCase
 {
-    public const STOCK_FLAG = 'has_stock_status_filter';
+    private const STOCK_FLAG = 'has_stock_status_filter';
 
     /** @var ObjectManager */
     private $objectManager;

app/code/Magento/Customer/Test/Unit/Block/Widget/DobTest.php

@@ -37,31 +37,31 @@
 class DobTest extends TestCase
 {
     /** Constants used in the unit tests */
-    public const MIN_DATE = '01/01/2010';
+    private const MIN_DATE = '01/01/2010';
 
-    public const MAX_DATE = '01/01/2020';
+    private const MAX_DATE = '01/01/2020';
 
-    public const DATE = '01/01/2014';
+    private const DATE = '01/01/2014';
 
-    public const DAY = '01';
+    private const DAY = '01';
 
     // Value of date('d', strtotime(self::DATE))
-    public const MONTH = '01';
+    private const MONTH = '01';
 
     // Value of date('m', strtotime(self::DATE))
-    public const YEAR = '2014';
+    private const YEAR = '2014';
 
     // Value of date('Y', strtotime(self::DATE))
-    public const DATE_FORMAT = 'M/dd/y';
+    private const DATE_FORMAT = 'M/dd/y';
 
     /** Constants used by Dob::setDateInput($code, $html) */
-    public const DAY_HTML =
+    private const DAY_HTML =
         '<div><label for="day"><span>d</span></label><input type="text" id="day" name="Day" value="1"></div>';
 
-    public const MONTH_HTML =
+    private const MONTH_HTML =
         '<div><label for="month"><span>M</span></label><input type="text" id="month" name="Month" value="jan"></div>';
 
-    public const YEAR_HTML =
+    private const YEAR_HTML =
         '<div><label for="year"><span>yy</span></label><input type="text" id="year" name="Year" value="14"></div>';
 
     /** @var MockObject|AttributeMetadataInterface */

lib/internal/Magento/Framework/Data/Test/Unit/SearchCriteriaBuilderTest.php

@@ -13,6 +13,10 @@
 use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
 use PHPUnit\Framework\TestCase;
 
+/**
+ *
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
+ */
 class SearchCriteriaBuilderTest extends TestCase
 {
     public function testMake()