Skip to content

Commit dbfe81c

Browse files
committed
Code simplification
1 parent afd51ce commit dbfe81c

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

app/code/Magento/QuoteGraphQl/Model/CartItem/ProductStock.php

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -53,13 +53,13 @@ public function isProductAvailable($cartItem): bool
5353
$previousQty = 0;
5454

5555
foreach ($cartItem->getQuote()->getItems() as $item) {
56-
if ($item->getItemId() == $cartItem->getItemId()) {
56+
if ($item->getItemId() === $cartItem->getItemId()) {
5757
$requestedQty = $item->getQtyToAdd() ?? $item->getQty();
5858
$previousQty = $item->getPreviousQty() ?? 0;
5959
}
6060
}
6161

62-
if ($cartItem->getProductType() == self::PRODUCT_TYPE_BUNDLE) {
62+
if ($cartItem->getProductType() === self::PRODUCT_TYPE_BUNDLE) {
6363
$qtyOptions = $cartItem->getQtyOptions();
6464
$totalRequestedQty = $previousQty + $requestedQty;
6565
foreach ($qtyOptions as $qtyOption) {
@@ -75,9 +75,7 @@ public function isProductAvailable($cartItem): bool
7575
} else {
7676
$requiredItemQty = $requestedQty + $previousQty;
7777
$productId = (int) $cartItem->getProduct()->getId();
78-
if (!$this->isStockAvailable($productId, $requiredItemQty)) {
79-
return false;
80-
}
78+
return $this->isStockAvailable($productId, $requiredItemQty);
8179
}
8280
return true;
8381
}

app/code/Magento/QuoteGraphQl/Model/Resolver/CheckProductStockAvailability.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,6 @@ public function resolve(Field $field, $context, ResolveInfo $info, array $value
5151
/** @var Item $cartItem */
5252
$cartItem = $value['model'];
5353

54-
return $this->productStock->isProductAvailable($cartItem) ? true : false;
54+
return $this->productStock->isProductAvailable($cartItem);
5555
}
5656
}

0 commit comments

Comments
 (0)