Skip to content

Commit dcc71bf

Browse files
author
Graham Wharton
committed
Removed Unnecessary type checking on tests
1 parent 2ce4ab0 commit dcc71bf

File tree

1 file changed

+0
-52
lines changed

1 file changed

+0
-52
lines changed

app/code/Magento/Catalog/Test/Unit/Block/Product/View/GalleryOptionsTest.php

Lines changed: 0 additions & 52 deletions
Original file line numberDiff line numberDiff line change
@@ -125,52 +125,21 @@ public function testGetOptionsJson()
125125
$decodedJson = $this->jsonSerializer->unserialize($json);
126126

127127
$this->assertSame('thumbs', $decodedJson['nav']);
128-
$this->assertInternalType("string", $decodedJson['nav']);
129-
130128
$this->assertSame(false, $decodedJson['loop']);
131-
$this->assertInternalType("bool", $decodedJson['loop']);
132-
133129
$this->assertSame(true, $decodedJson['keyboard']);
134-
$this->assertInternalType("bool", $decodedJson['keyboard']);
135-
136130
$this->assertSame(true, $decodedJson['arrows']);
137-
$this->assertInternalType("bool", $decodedJson['arrows']);
138-
139131
$this->assertSame(false, $decodedJson['showCaption']);
140-
$this->assertInternalType("bool", $decodedJson['showCaption']);
141-
142132
$this->assertSame(true, $decodedJson['allowfullscreen']);
143-
$this->assertInternalType("bool", $decodedJson['allowfullscreen']);
144-
145133
$this->assertSame('horizontal', $decodedJson['navdir']);
146-
$this->assertInternalType("string", $decodedJson['navdir']);
147-
148134
$this->assertSame(true, $decodedJson['navarrows']);
149-
$this->assertInternalType("bool", $decodedJson['navarrows']);
150-
151135
$this->assertSame('slides', $decodedJson['navtype']);
152-
$this->assertInternalType("string", $decodedJson['navtype']);
153-
154136
$this->assertSame(5, $decodedJson['thumbmargin']);
155-
$this->assertInternalType("int", $decodedJson['thumbmargin']);
156-
157137
$this->assertSame('slide', $decodedJson['transition']);
158-
$this->assertInternalType("string", $decodedJson['transition']);
159-
160138
$this->assertSame(500, $decodedJson['transitionduration']);
161-
$this->assertInternalType("int", $decodedJson['transitionduration']);
162-
163139
$this->assertSame(100, $decodedJson['height']);
164-
$this->assertInternalType("int", $decodedJson['height']);
165-
166140
$this->assertSame(200, $decodedJson['width']);
167-
$this->assertInternalType("int", $decodedJson['width']);
168-
169141
$this->assertSame(300, $decodedJson['thumbheight']);
170-
$this->assertInternalType("int", $decodedJson['thumbheight']);
171-
172142
$this->assertSame(400, $decodedJson['thumbwidth']);
173-
$this->assertInternalType("int", $decodedJson['thumbwidth']);
174143
}
175144

176145
public function testGetFSOptionsJson()
@@ -200,37 +169,16 @@ public function testGetFSOptionsJson()
200169
//Note, this tests the special case for nav variable set to false. It
201170
//Should not be converted to boolean.
202171
$this->assertSame('false', $decodedJson['nav']);
203-
$this->assertInternalType("string", $decodedJson['nav']);
204-
205172
$this->assertSame(true, $decodedJson['loop']);
206-
$this->assertInternalType("bool", $decodedJson['loop']);
207-
208173
$this->assertSame(false, $decodedJson['arrows']);
209-
$this->assertInternalType("bool", $decodedJson['arrows']);
210-
211174
$this->assertSame(true, $decodedJson['keyboard']);
212-
$this->assertInternalType("bool", $decodedJson['keyboard']);
213-
214175
$this->assertSame(true, $decodedJson['showCaption']);
215-
$this->assertInternalType("bool", $decodedJson['showCaption']);
216-
217176
$this->assertSame('vertical', $decodedJson['navdir']);
218-
$this->assertInternalType("string", $decodedJson['navdir']);
219-
220177
$this->assertSame(false, $decodedJson['navarrows']);
221-
$this->assertInternalType("bool", $decodedJson['navarrows']);
222-
223178
$this->assertSame(10, $decodedJson['thumbmargin']);
224-
$this->assertInternalType("int", $decodedJson['thumbmargin']);
225-
226179
$this->assertSame('thumbs', $decodedJson['navtype']);
227-
$this->assertInternalType("string", $decodedJson['navtype']);
228-
229180
$this->assertSame('dissolve', $decodedJson['transition']);
230-
$this->assertInternalType("string", $decodedJson['transition']);
231-
232181
$this->assertSame(300, $decodedJson['transitionduration']);
233-
$this->assertInternalType("int", $decodedJson['transitionduration']);
234182
}
235183

236184
public function testGetOptionsJsonOptionals()

0 commit comments

Comments
 (0)